Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more paths for kibana docs #1904

Merged
merged 5 commits into from
Jul 20, 2020
Merged

Add more paths for kibana docs #1904

merged 5 commits into from
Jul 20, 2020

Conversation

gtback
Copy link
Member

@gtback gtback commented Jul 16, 2020

The Kibana docs will be including developer-facing material that is co-located with source code.

The Kibana docs will be including developer-facing material that is
co-located with source code.
@gtback
Copy link
Member Author

gtback commented Jul 16, 2020

I expect this might fail if there aren't any files that match those paths in the Kibana repo currently.

Copy link

@stacey-gammon stacey-gammon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!!

@gtback
Copy link
Member Author

gtback commented Jul 16, 2020

If #1898 gets merged first, we'll need to add the new 7.9 branch into exclude_branches here, otherwise we'll need to make that change in #1898.

@gtback gtback marked this pull request as ready for review July 16, 2020 15:31
@gtback gtback self-assigned this Jul 16, 2020
@gtback gtback added the docs-build Relates to the build tooling and scripts label Jul 16, 2020
@gtback
Copy link
Member Author

gtback commented Jul 16, 2020

If #1898 gets merged first, we'll need to add the new 7.9 branch into exclude_branches here, otherwise we'll need to make that change in #1898.

This got merged, so I need to go back and add 7.9 in. I'll wait until the Kibana PRs are merged first, though, so that the builds should pass.

@gtback gtback marked this pull request as draft July 16, 2020 20:27
@gtback gtback marked this pull request as ready for review July 20, 2020 14:36
@gtback
Copy link
Member Author

gtback commented Jul 20, 2020

This should be good to merge once tests pass!

@gtback
Copy link
Member Author

gtback commented Jul 20, 2020

@elasticmachine run elasticsearch-ci/docs

@gtback gtback merged commit 65289d6 into master Jul 20, 2020
@gtback gtback deleted the add-kibana-paths branch July 20, 2020 16:43
gtback added a commit that referenced this pull request Jul 20, 2020
This reverts commit 65289d6, reversing
changes made to e74be1b.
@gtback gtback mentioned this pull request Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-build Relates to the build tooling and scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants