Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a few asciidoc readmes #72082

Merged

Conversation

stacey-gammon
Copy link
Contributor

This is needed so elastic/docs#1904 doesn't fail ci. The goal is eventually to link to these asciidoc readmes from the developer guide after some additional work on top of #71731 to support asciidoc and <> links instead of links to the READMEs inside github.

Copy link
Member

@gtback gtback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the docs side

@stacey-gammon stacey-gammon marked this pull request as ready for review July 16, 2020 18:02
@stacey-gammon stacey-gammon requested a review from a team July 16, 2020 18:02
@stacey-gammon stacey-gammon requested review from a team as code owners July 16, 2020 18:02
@stacey-gammon stacey-gammon added release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0 Team:Operations Team label for Operations Team labels Jul 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

… add asciidoc support. The snippet didn't show up anyway.
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Precommit hook changes LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stacey-gammon stacey-gammon merged commit 6a03e8b into elastic:master Jul 17, 2020
stacey-gammon added a commit to stacey-gammon/kibana that referenced this pull request Jul 17, 2020
* Add a few asciidoc readmes

* add updated code-exploration. Need to fix the script in another go to add asciidoc support. The snippet didn't show up anyway.
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 17, 2020
* master:
  [ML] Remove DragSelect event handlers and selectors on the swim lane unmount  (elastic#72250)
  Add a few asciidoc readmes (elastic#72082)
  re-enable tests. retry on fail (elastic#72061)
  updates advanced settings text (elastic#72249)
  [ML] Fix HTML named characters encoding (elastic#72060)
  Bump @elastic/elasticsearch to v7.9.0-rc1 (elastic#72231)
  Observability landing page title (elastic#72088)
  [QA][Code Coverage] Drop flaky integration tests (elastic#72089)
  [Ingest Manager] Fix failing test conflict error (elastic#72149)
  [Logs UI] Fix display of dataset values in anomaly and category example rows (elastic#71693)
  [SECURITY] Bug truncation on timeline (elastic#72221)
  skip flaky suite (elastic#72146)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 17, 2020
…feature-privileges

* alerting/consumer-based-rbac:
  corrected consumer on enable operation
  [ML] Remove DragSelect event handlers and selectors on the swim lane unmount  (elastic#72250)
  Add a few asciidoc readmes (elastic#72082)
  re-enable tests. retry on fail (elastic#72061)
  updates advanced settings text (elastic#72249)
  [ML] Fix HTML named characters encoding (elastic#72060)
  Bump @elastic/elasticsearch to v7.9.0-rc1 (elastic#72231)
  Observability landing page title (elastic#72088)
  [QA][Code Coverage] Drop flaky integration tests (elastic#72089)
  [Ingest Manager] Fix failing test conflict error (elastic#72149)
  [Logs UI] Fix display of dataset values in anomaly and category example rows (elastic#71693)
  [SECURITY] Bug truncation on timeline (elastic#72221)
  skip flaky suite (elastic#72146)
chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Jul 17, 2020
* Add a few asciidoc readmes

* add updated code-exploration. Need to fix the script in another go to add asciidoc support. The snippet didn't show up anyway.
stacey-gammon added a commit that referenced this pull request Jul 20, 2020
* Add a few asciidoc readmes

* add updated code-exploration. Need to fix the script in another go to add asciidoc support. The snippet didn't show up anyway.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants