Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs UI] Fix display of dataset values in anomaly and category example rows #71693

Merged
merged 2 commits into from
Jul 17, 2020
Merged

[Logs UI] Fix display of dataset values in anomaly and category example rows #71693

merged 2 commits into from
Jul 17, 2020

Conversation

weltenwort
Copy link
Member

Summary

This removes an unnecessary JSON encoding step of values before they are passed to the field column component used in the log entry example rows in both the Anomalies and Categories tabs. A change in #54280 removed the decoding step from the component which lead to an incorrect display of encoded values.

closes #71415

Previews

Before

image

After

image

@weltenwort weltenwort added release_note:fix v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 14, 2020
@weltenwort weltenwort added this to the Logs UI 7.9 milestone Jul 14, 2020
@weltenwort weltenwort self-assigned this Jul 14, 2020
@weltenwort
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
infra 4.7MB -345.0B 4.7MB

miscellaneous assets size

id value diff baseline
upgradeAssistant 22.6KB +11.0B 22.6KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jasonrhodes jasonrhodes added the bug Fixes for quality problems that affect the customer experience label Jul 16, 2020
@weltenwort weltenwort removed the release_note:skip Skip the PR/issue when compiling release notes label Jul 17, 2020
@weltenwort weltenwort marked this pull request as ready for review July 17, 2020 11:41
@weltenwort weltenwort requested a review from a team as a code owner July 17, 2020 11:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@afgomez afgomez self-requested a review July 17, 2020 11:44
afgomez
afgomez approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@afgomez afgomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended 👍

@weltenwort weltenwort merged commit 44888d3 into elastic:master Jul 17, 2020
@weltenwort weltenwort deleted the logs-ui-fix-field-column-encoding branch July 17, 2020 13:08
This was referenced Jul 17, 2020
Merged
Merged
weltenwort added a commit to weltenwort/kibana that referenced this pull request Jul 17, 2020
@weltenwort
[Logs UI] Fix display of dataset values in anomaly and category examp…
88e9dc2 
…le rows (elastic#71693)

This removes an unnecessary JSON encoding step of values before they are passed to the field column component used in the log entry example rows in both the Anomalies and Categories tabs.
weltenwort added a commit that referenced this pull request Jul 17, 2020
@weltenwort
[7.x] [Logs UI] Fix display of dataset values in anomaly and category…
b022530 
… example rows (#71693) (#72272)

Backports the following commits to 7.x:
 - [Logs UI] Fix display of dataset values in anomaly and category example rows (#71693)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 17, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
16ab6c6 
* master:
  [ML] Remove DragSelect event handlers and selectors on the swim lane unmount  (elastic#72250)
  Add a few asciidoc readmes (elastic#72082)
  re-enable tests. retry on fail (elastic#72061)
  updates advanced settings text (elastic#72249)
  [ML] Fix HTML named characters encoding (elastic#72060)
  Bump @elastic/elasticsearch to v7.9.0-rc1 (elastic#72231)
  Observability landing page title (elastic#72088)
  [QA][Code Coverage] Drop flaky integration tests (elastic#72089)
  [Ingest Manager] Fix failing test conflict error (elastic#72149)
  [Logs UI] Fix display of dataset values in anomaly and category example rows (elastic#71693)
  [SECURITY] Bug truncation on timeline (elastic#72221)
  skip flaky suite (elastic#72146)
weltenwort added a commit that referenced this pull request Jul 17, 2020
@weltenwort
[7.9] [Logs UI] Fix display of dataset values in anomaly and category…
bfb3bb9 
… example rows (#71693) (#72273)

Backports the following commits to 7.9:
 - [Logs UI] Fix display of dataset values in anomaly and category example rows (#71693)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 17, 2020
@gmmorris
Merge branch 'alerting/consumer-based-rbac' into alerting/management-…
186cbe0 
…feature-privileges

* alerting/consumer-based-rbac:
  corrected consumer on enable operation
  [ML] Remove DragSelect event handlers and selectors on the swim lane unmount  (elastic#72250)
  Add a few asciidoc readmes (elastic#72082)
  re-enable tests. retry on fail (elastic#72061)
  updates advanced settings text (elastic#72249)
  [ML] Fix HTML named characters encoding (elastic#72060)
  Bump @elastic/elasticsearch to v7.9.0-rc1 (elastic#72231)
  Observability landing page title (elastic#72088)
  [QA][Code Coverage] Drop flaky integration tests (elastic#72089)
  [Ingest Manager] Fix failing test conflict error (elastic#72149)
  [Logs UI] Fix display of dataset values in anomaly and category example rows (elastic#71693)
  [SECURITY] Bug truncation on timeline (elastic#72221)
  skip flaky suite (elastic#72146)
chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Jul 17, 2020
@weltenwort @chrisronline
[Logs UI] Fix display of dataset values in anomaly and category examp…
ce191f1 
…le rows (elastic#71693)

This removes an unnecessary JSON encoding step of values before they are passed to the field column component used in the log entry example rows in both the Anomalies and Categories tabs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afgomez afgomez afgomez approved these changes

Assignees

@weltenwort weltenwort

Labels
bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature release_note:fix Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 v8.0.0
Projects
None yet
Milestone
Logs UI 7.9
Development

Successfully merging this pull request may close these issues.

[Logs UI] Dataset field columns are erroneously being JSON-encoded
5 participants
@weltenwort @kibanamachine @elasticmachine @afgomez @jasonrhodes