Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the --update-head-ok to fetch for PRs out of main #2904

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

nkammah
Copy link
Contributor

@nkammah nkammah commented Jan 25, 2024

It seems like docs PR coming from a local main branch fail to checkout on Buildkite with the error:
fatal: Refusing to fetch into current branch refs/heads/main of non-bare repository

This PR attempts solves the issue by using the --update-head-ok flag - see explanation in this stack overflow.

Note - this also addresses the issue where status checks were not reported when the build was failing

This was tested using one of the problematic PR:

  • reproducing the failure
  • with the fix (additional flag) (but then aborting the build)

Copy link

A documentation preview will be available soon.

Help us out by validating the Buildkite preview and reporting issues here.
Please also be sure to double check all images to ensure they are correct in the preview.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Also - add more verbose on status check reporting
@nkammah nkammah marked this pull request as ready for review January 25, 2024 10:58
@nkammah nkammah requested a review from a team as a code owner January 25, 2024 10:58
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks!

@bmorelli25 bmorelli25 merged commit 85d05d9 into master Jan 25, 2024
5 checks passed
@bmorelli25 bmorelli25 deleted the fetch-updated-head-ok branch January 25, 2024 15:44
bmorelli25 added a commit to bmorelli25/docs that referenced this pull request Jan 26, 2024
bmorelli25 added a commit that referenced this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants