Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix product repo PR checkout #2913

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Fix product repo PR checkout #2913

merged 3 commits into from
Jan 29, 2024

Conversation

nkammah
Copy link
Contributor

@nkammah nkammah commented Jan 28, 2024

In #2904 we tried to fix the PR checkout mechanism to work even when the branch name of the original PR matched an existing branch name, such as main. This turned out to be creating some issues and was reverted in 0854c6e.

In this PR, we checkout the PR into a local pr_ head, to avoid any sort of conflicts.

@nkammah nkammah requested a review from a team as a code owner January 28, 2024 18:36
Copy link

A documentation preview will be available soon.

Help us out by validating the Buildkite preview and reporting issues here.
Please also be sure to double check all images to ensure they are correct in the preview.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@nkammah nkammah merged commit 080b767 into master Jan 29, 2024
4 of 5 checks passed
@nkammah nkammah deleted the fix-product-repo-cloning branch January 29, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants