Skip to content
This repository has been archived by the owner on Sep 17, 2024. It is now read-only.

Allow downloading artifacts from project specific locations #3622

Merged
merged 7 commits into from
Aug 21, 2023

Conversation

cmacknz
Copy link
Member

@cmacknz cmacknz commented Aug 21, 2023

This PR fixes several bugs and makes it possible to download artifacts from the project specific staging areas that feed into the unified release process. This is necessary in the time between a feature freeze and the first snapshot being produced, which historically has been several days.

Examples of project specific URLs are:

This also makes the following changes:

  • Adds mutexes to shared caches to allow downloads to happen in parallel safely.
  • Remove use of the curl package in favor of the stdlib
  • Improve logging, both by using less of it and including the name of the resolver that generated the log.

To test this PR, check out https://github.com/cmacknz/elastic-agent/tree/fix-artifacts-api-usage and replace the e2e-testing dependency with this version. The build will succeed, where as it fails on main. The draft PR for this change without the dependency update is elastic/elastic-agent#3273.

To see what the new logging looks like, change to InfoLevel logging instead of FatalLevel in https://github.com/cmacknz/elastic-agent/blob/5c28f4e975748c0f63af9c653124ca4bd4e2a74b/magefile.go#L953

@cmacknz cmacknz added the Team:Elastic-Agent Label for the Agent team label Aug 21, 2023
@cmacknz cmacknz self-assigned this Aug 21, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2023

This pull request does not have a backport label. Could you fix it @cmacknz? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Aug 21, 2023
@cmacknz cmacknz merged commit 6ee6b7a into elastic:main Aug 21, 2023
@cmacknz cmacknz deleted the fix-use-of-snapshot-artifacts-api branch August 21, 2023 22:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport-skip Skip notification from the automated backport with mergify Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants