This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
Allow downloading artifacts from project specific locations #3622
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several bugs and makes it possible to download artifacts from the project specific staging areas that feed into the unified release process. This is necessary in the time between a feature freeze and the first snapshot being produced, which historically has been several days.
Examples of project specific URLs are:
This also makes the following changes:
To test this PR, check out https://github.com/cmacknz/elastic-agent/tree/fix-artifacts-api-usage and replace the e2e-testing dependency with this version. The build will succeed, where as it fails on main. The draft PR for this change without the dependency update is elastic/elastic-agent#3273.
To see what the new logging looks like, change to
InfoLevel
logging instead ofFatalLevel
in https://github.com/cmacknz/elastic-agent/blob/5c28f4e975748c0f63af9c653124ca4bd4e2a74b/magefile.go#L953