Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the e2e-testing dependency and unblock 8.11 buiilds #3273

Merged
merged 5 commits into from
Aug 22, 2023
Merged

Update the e2e-testing dependency and unblock 8.11 buiilds #3273

merged 5 commits into from
Aug 22, 2023

Conversation

cmacknz
Copy link
Member

@cmacknz cmacknz commented Aug 21, 2023 •
edited
Loading

Update the e2e-testing dependency and allow the agent to build before an official snapshot is ready. For the build to succeed we only need the packaging job of each artifact we depend on to succeed once with the new version number.

The only major change here is that each artifact we download now needs to be linked back to its project name in the unified release manager. This is done with a simple map.

I also changed the download logic to attempt the downloads concurrently, which speeds them up slightly.

@cmacknz cmacknz added the Team:Elastic-Agent Label for the Agent team label Aug 21, 2023
@cmacknz cmacknz requested review from AndersonQ and pazone August 21, 2023 20:35
@cmacknz cmacknz self-assigned this Aug 21, 2023
@cmacknz cmacknz mentioned this pull request Aug 21, 2023
Merged
@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2023

This pull request does not have a backport label. Could you fix it @cmacknz? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@elasticmachine
Copy link
Contributor

elasticmachine commented Aug 21, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-21T22:38:12.124+0000

  • Duration: 27 min 29 sec

Test stats 🧪

Test Results
Failed 0
Passed 6277
Skipped 47
Total 6324

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

cmacknz added 2 commits August 21, 2023 18:34
@cmacknz
Update e2e-testing to v1.1.0.
6edf755 
Adds ability to download from project specific snapshots.
@cmacknz
Improve log messages slightly.
35dcb59
@cmacknz cmacknz marked this pull request as ready for review August 21, 2023 22:37
@cmacknz cmacknz requested a review from a team as a code owner August 21, 2023 22:37
@cmacknz cmacknz requested a review from pchila August 21, 2023 22:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@cmacknz cmacknz requested a review from ycombinator August 21, 2023 22:38
@cmacknz
Copy link
Member Author

cmacknz commented Aug 21, 2023

The packaging jobs should succeed with this change before the official 8.11 snapshot is ready. To tell if this works after the 8.11 unified snapshot we'll need to look at the logs.

@cmacknz cmacknz enabled auto-merge (squash) August 21, 2023 22:40
ycombinator
ycombinator approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@ycombinator ycombinator left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with SNAPSHOT=true EXTERNAL=true DEV=true PLATFORMS=linux/arm64 PACKAGES=tar.gz mage package and it works with this PR! The same command has been failing on main for the past few days.

Also noticed the speedup with the concurrent downloading of artifacts, which is nice 👍.

@elasticmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.75% (79/80) 👍
Files 67.832% (194/286) 👍
Classes 66.292% (354/534) 👍
Methods 52.874% (1104/2088) 👍
Lines 38.719% (12654/32682) 👍 0.058
Conditionals 100.0% (0/0) 💚

@cmacknz
Copy link
Member Author

cmacknz commented Aug 22, 2023 

>> (linux-arm64-ubuntu-2204) Failed for instance linux-arm64-ubuntu-2204 (@ 34.135.199.225): ogc-linux-arm64-ubuntu-2204-89f5 unable to continue because stack never became ready: failed to create ESS cloud for version 8.11.0-SNAPSHOT: failed to create: (clusters.cluster_invalid_plan) Version [8.11.0-SNAPSHOT] is not available. Please use one of the available versions

I am going to force merge this to get us past the build errors. Will keep iterating on actually fixing the tests.

@cmacknz cmacknz disabled auto-merge August 22, 2023 00:28
@cmacknz cmacknz merged commit 2675646 into elastic:main Aug 22, 2023
@cmacknz cmacknz deleted the fix-artifacts-api-usage branch August 22, 2023 00:28
AndersonQ pushed a commit to AndersonQ/elastic-agent that referenced this pull request Aug 24, 2023
@cmacknz @AndersonQ
Update the e2e-testing dependency and unblock 8.11 buiilds (elastic#3273
2f16a66 
)

* Update e2e-testing to fix artifacts API.

* Allow downloading snapshot versions.

* Improve comment on log level.

* Update e2e-testing to v1.1.0.

Adds ability to download from project specific snapshots.

* Improve log messages slightly.
AndersonQ pushed a commit to AndersonQ/elastic-agent that referenced this pull request Aug 24, 2023
@cmacknz @AndersonQ
Revert "Update the e2e-testing dependency and unblock 8.11 buiilds (e…
845f24e 
…lastic#3273)"

This reverts commit 2f16a66.
@cmacknz cmacknz added the backport-v8.10.0 Automated backport with mergify label Sep 14, 2023
mergify bot pushed a commit that referenced this pull request Sep 14, 2023
@cmacknz @mergify
Update the e2e-testing dependency and unblock 8.11 buiilds (#3273)
931a8aa 
* Update e2e-testing to fix artifacts API.

* Allow downloading snapshot versions.

* Improve comment on log level.

* Update e2e-testing to v1.1.0.

Adds ability to download from project specific snapshots.

* Improve log messages slightly.

(cherry picked from commit 2675646)
@mergify mergify bot mentioned this pull request Sep 14, 2023
Merged
pierrehilbert pushed a commit that referenced this pull request Sep 14, 2023
@mergify @cmacknz
Update the e2e-testing dependency and unblock 8.11 buiilds (#3273) (#…
ccfb23c 
…3417)

* Update e2e-testing to fix artifacts API.

* Allow downloading snapshot versions.

* Improve comment on log level.

* Update e2e-testing to v1.1.0.

Adds ability to download from project specific snapshots.

* Improve log messages slightly.

(cherry picked from commit 2675646)

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycombinator ycombinator ycombinator approved these changes

@AndersonQ AndersonQ Awaiting requested review from AndersonQ

@pazone pazone Awaiting requested review from pazone

@pchila pchila Awaiting requested review from pchila pchila is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@cmacknz cmacknz

Labels
backport-skip backport-v8.10.0 Automated backport with mergify skip-changelog Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Elastic Agent relies on artifacts-api for fetching the dependent artifacts when running the packaging
3 participants
@cmacknz @elasticmachine @ycombinator