Enhancement/5235 use disk space error to set upgrade detail in coordinator #9392

kaanyalti · 2025-08-15T15:59:44Z

PR 6/6

Enhancement

What does this PR do?

Updates the coordinator upgrade function.
- If an upgrade fails with insufficient disk space error the coordinator sets the error to ErrInsufficientDiskSpaceError
Addresses this comment Agent reports if there is insufficient disk space during upgrade, cleans up, and prevents upgrade #5235 (comment) in the parent issue

Why is it important?

Disk space errors are not user friendly, so when the upgrade state shows the os disk space error the status output and the fleet ui gets cluttered.
By setting the detail error to ErrInsufficientDiskSpaceError we are now providing a consistent and concise error message to the user.

Checklist

I have read and understood the pull request guidelines of this project.
My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
~~[ ] I have made corresponding changes to the documentation~~
~~[ ] I have made corresponding change to the default configuration files~~
I have added tests that prove my fix is effective or that my feature works
~~[ ] I have added an entry in ./changelog/fragments using the changelog tool~~
~~[ ] I have added an integration test or an E2E test~~

Disruptive User Impact

none

How to test this PR locally

Coordinator unit test is sufficient

Related issues

elasticmachine · 2025-08-15T15:59:47Z

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

kaanyalti · 2025-08-15T16:00:29Z

~~The changelog relevant to this pr is added in #9122~~
~~The changelog will be in a separate PR~~

internal/pkg/agent/application/coordinator/coordinator.go

kaanyalti · 2025-08-20T13:04:02Z

@ycombinator @michalpristas
Added logging as mentioned in the comment, requested re-review

mergify · 2025-09-09T01:17:22Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b enhancement/5235_use_disk_space_error_to_set_upgrade_detail_in_coordinator upstream/enhancement/5235_use_disk_space_error_to_set_upgrade_detail_in_coordinator
git merge upstream/main
git push upstream enhancement/5235_use_disk_space_error_to_set_upgrade_detail_in_coordinator

elasticmachine · 2025-09-12T17:54:14Z

⏳ Build in-progress, with failures

Buildkite Build
Commit: c140eca

Failed CI Steps

History

💚 Build #26384 succeeded d7e8924
💛 Build #26290 was flaky 79185f3
💔 Build #26221 failed 79185f3
💛 Build #25565 was flaky f015070

cc @kaanyalti

mergify · 2025-09-14T19:12:26Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b enhancement/5235_use_disk_space_error_to_set_upgrade_detail_in_coordinator upstream/enhancement/5235_use_disk_space_error_to_set_upgrade_detail_in_coordinator
git merge upstream/main
git push upstream enhancement/5235_use_disk_space_error_to_set_upgrade_detail_in_coordinator

…e coordinator

…e error enhancement(5235): updated error in test enhancement(5235): fix coordinator test

elastic-sonarqube · 2025-09-18T20:48:57Z

Quality Gate passed

Issues
1 New issue
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

github-actions · 2025-09-19T11:37:53Z

@Mergifyio backport 8.18 8.19 9.0 9.1

mergify · 2025-09-19T11:38:04Z

backport 8.18 8.19 9.0 9.1

✅ Backports have been created

#10054 [8.18] (backport #9392) Enhancement/5235 use disk space error to set upgrade detail in coordinator has been created for branch 8.18 but encountered conflicts
#10055 [8.19] (backport #9392) Enhancement/5235 use disk space error to set upgrade detail in coordinator has been created for branch 8.19 but encountered conflicts
#10056 [9.0] (backport #9392) Enhancement/5235 use disk space error to set upgrade detail in coordinator has been created for branch 9.0 but encountered conflicts
#10057 [9.1] (backport #9392) Enhancement/5235 use disk space error to set upgrade detail in coordinator has been created for branch 9.1 but encountered conflicts

…nator (#9392) * enhancement(5235): added insufficinet disk space error handling in the coordinator * enhancement(5235): added coordinator tests for insufficient disk space error enhancement(5235): updated error in test enhancement(5235): fix coordinator test * enhancement(5235): added changelog fragment (cherry picked from commit a7a76f6) # Conflicts: # internal/pkg/agent/application/coordinator/coordinator_unit_test.go

…nator (elastic#9392) * enhancement(5235): added insufficinet disk space error handling in the coordinator * enhancement(5235): added coordinator tests for insufficient disk space error enhancement(5235): updated error in test enhancement(5235): fix coordinator test * enhancement(5235): added changelog fragment

…upgrade detail in coordinator (#10054) * Enhancement/5235 use disk space error to set upgrade detail in coordinator (#9392) * enhancement(5235): added insufficinet disk space error handling in the coordinator * enhancement(5235): added coordinator tests for insufficient disk space error enhancement(5235): updated error in test enhancement(5235): fix coordinator test * enhancement(5235): added changelog fragment (cherry picked from commit a7a76f6) # Conflicts: # internal/pkg/agent/application/coordinator/coordinator_unit_test.go * resolved merge conflicts --------- Co-authored-by: Kaan Yalti <kaan.yalti@elastic.co>

…upgrade detail in coordinator (#10055) * Enhancement/5235 use disk space error to set upgrade detail in coordinator (#9392) * enhancement(5235): added insufficinet disk space error handling in the coordinator * enhancement(5235): added coordinator tests for insufficient disk space error enhancement(5235): updated error in test enhancement(5235): fix coordinator test * enhancement(5235): added changelog fragment (cherry picked from commit a7a76f6) # Conflicts: # internal/pkg/agent/application/coordinator/coordinator_unit_test.go * resolved merge conflicts --------- Co-authored-by: Kaan Yalti <kaan.yalti@elastic.co>

…pgrade detail in coordinator (#10056) * Enhancement/5235 use disk space error to set upgrade detail in coordinator (#9392) * enhancement(5235): added insufficinet disk space error handling in the coordinator * enhancement(5235): added coordinator tests for insufficient disk space error enhancement(5235): updated error in test enhancement(5235): fix coordinator test * enhancement(5235): added changelog fragment (cherry picked from commit a7a76f6) # Conflicts: # internal/pkg/agent/application/coordinator/coordinator_unit_test.go * resolved merge conflicts --------- Co-authored-by: Kaan Yalti <kaan.yalti@elastic.co>

…pgrade detail in coordinator (#10057) * Enhancement/5235 use disk space error to set upgrade detail in coordinator (#9392) * enhancement(5235): added insufficinet disk space error handling in the coordinator * enhancement(5235): added coordinator tests for insufficient disk space error enhancement(5235): updated error in test enhancement(5235): fix coordinator test * enhancement(5235): added changelog fragment (cherry picked from commit a7a76f6) # Conflicts: # internal/pkg/agent/application/coordinator/coordinator_unit_test.go * resolved merge conflicts --------- Co-authored-by: Kaan Yalti <kaan.yalti@elastic.co>

kaanyalti requested a review from a team as a code owner August 15, 2025 15:59

kaanyalti added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team skip-changelog backport-active-all Automated backport with mergify to all the active branches labels Aug 15, 2025

kaanyalti requested review from michalpristas and ycombinator August 15, 2025 15:59

mergify bot assigned kaanyalti Aug 15, 2025

michalpristas previously approved these changes Aug 19, 2025

View reviewed changes

internal/pkg/agent/application/coordinator/coordinator.go Show resolved Hide resolved

ycombinator previously approved these changes Aug 19, 2025

View reviewed changes

kaanyalti dismissed stale reviews from ycombinator and michalpristas via f015070 August 20, 2025 13:01

kaanyalti force-pushed the enhancement/5235_use_disk_space_error_to_set_upgrade_detail_in_coordinator branch from 5a177cd to f015070 Compare August 20, 2025 13:01

kaanyalti requested review from michalpristas and ycombinator August 20, 2025 13:03

kaanyalti marked this pull request as draft September 2, 2025 13:09

kaanyalti force-pushed the enhancement/5235_use_disk_space_error_to_set_upgrade_detail_in_coordinator branch from f015070 to 5a4ed2a Compare September 4, 2025 18:33

kaanyalti removed the skip-changelog label Sep 4, 2025

kaanyalti force-pushed the enhancement/5235_use_disk_space_error_to_set_upgrade_detail_in_coordinator branch from 79185f3 to d7e8924 Compare September 8, 2025 18:38

kaanyalti force-pushed the enhancement/5235_use_disk_space_error_to_set_upgrade_detail_in_coordinator branch from d7e8924 to c140eca Compare September 12, 2025 17:36

Kaan Yalti added 3 commits September 18, 2025 20:39

enhancement(5235): added insufficinet disk space error handling in th…

52c009d

…e coordinator

enhancement(5235): added coordinator tests for insufficient disk spac…

13443aa

…e error enhancement(5235): updated error in test enhancement(5235): fix coordinator test

enhancement(5235): added changelog fragment

c52f40f

kaanyalti force-pushed the enhancement/5235_use_disk_space_error_to_set_upgrade_detail_in_coordinator branch from c140eca to c52f40f Compare September 18, 2025 17:45

kaanyalti marked this pull request as ready for review September 19, 2025 00:54

michalpristas approved these changes Sep 19, 2025

View reviewed changes

kaanyalti merged commit a7a76f6 into elastic:main Sep 19, 2025
23 checks passed

mergify bot mentioned this pull request Sep 19, 2025

[8.18] (backport #9392) Enhancement/5235 use disk space error to set upgrade detail in coordinator #10054

Merged

4 tasks

This was referenced Sep 19, 2025

[8.19] (backport #9392) Enhancement/5235 use disk space error to set upgrade detail in coordinator #10055

Merged

[9.0] (backport #9392) Enhancement/5235 use disk space error to set upgrade detail in coordinator #10056

Merged

mergify bot mentioned this pull request Sep 19, 2025

[9.1] (backport #9392) Enhancement/5235 use disk space error to set upgrade detail in coordinator #10057

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Enhancement/5235 use disk space error to set upgrade detail in coordinator #9392

Enhancement/5235 use disk space error to set upgrade detail in coordinator #9392

Uh oh!

kaanyalti commented Aug 15, 2025 •

edited

Loading

Uh oh!

elasticmachine commented Aug 15, 2025

Uh oh!

kaanyalti commented Aug 15, 2025 •

edited

Loading

Uh oh!

Uh oh!

kaanyalti commented Aug 20, 2025

Uh oh!

mergify bot commented Sep 9, 2025

Uh oh!

elasticmachine commented Sep 12, 2025 •

edited

Loading

Uh oh!

mergify bot commented Sep 14, 2025

Uh oh!

elastic-sonarqube bot commented Sep 18, 2025

Uh oh!

Uh oh!

github-actions bot commented Sep 19, 2025

Uh oh!

mergify bot commented Sep 19, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Enhancement/5235 use disk space error to set upgrade detail in coordinator #9392

Enhancement/5235 use disk space error to set upgrade detail in coordinator #9392

Uh oh!

Conversation

kaanyalti commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Why is it important?

Checklist

Disruptive User Impact

How to test this PR locally

Related issues

Uh oh!

elasticmachine commented Aug 15, 2025

Uh oh!

kaanyalti commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

kaanyalti commented Aug 20, 2025

Uh oh!

mergify bot commented Sep 9, 2025

Uh oh!

elasticmachine commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⏳ Build in-progress, with failures

Failed CI Steps

History

Uh oh!

mergify bot commented Sep 14, 2025

Uh oh!

elastic-sonarqube bot commented Sep 18, 2025

Quality Gate passed

Uh oh!

Uh oh!

github-actions bot commented Sep 19, 2025

Uh oh!

mergify bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kaanyalti commented Aug 15, 2025 •

edited

Loading

kaanyalti commented Aug 15, 2025 •

edited

Loading

elasticmachine commented Sep 12, 2025 •

edited

Loading

mergify bot commented Sep 19, 2025 •

edited

Loading