[CI] Enable wolfi Elastic Agent images in tests #2067
Conversation
| @@ -17,6 +17,7 @@ inputs: | |||
| - apache-access | |||
| type: logfile | |||
| use_output: default | |||
| namespaces: [] | |||
There was a problem hiding this comment.
It looks like that for policy tests it should also be needed to be able to mark some fields optional @jsoriano
This namespaces field appeared when testing with 8.16.0-SNAPSHOT. But they are not present in older stack versions (e.g. 8.15.0).
Changes required present in these two commits:
There was a problem hiding this comment.
Reverting these two commits in order to be able to merge this PR.
| // Try to keep the test agnostic from the environment variables defined in CI | ||
| t.Setenv(disableElasticAgentWolfiEnvVar, "") | ||
| os.Unsetenv(disableElasticAgentWolfiEnvVar) |
There was a problem hiding this comment.
Could this cause any issues ?
It looks like the environment variable is defined in other tests even here it is unset.
There was a problem hiding this comment.
Setting environment variables is only going to be problematic if tests are run in parallel, as it affects the global process. t.Setenv recovers the previous value on cleanup, see https://pkg.go.dev/testing#B.Setenv.
There was a problem hiding this comment.
Perfect, so as these tests do not use t.Parallel(), I guess it is safe here. Even if it is called os.Unsetenv , the environment variable would be recovered aftwards thanks to the t.Setenv()
t.Parallel() is used in other tests:
- internal/servicedeployer/terraform_test.go
- internal/testrunner/runners/system/tester_test.go
There was a problem hiding this comment.
I think each package is executed in a different process, so we should be fine if the tests are in different packages.
💛 Build succeeded, but was flaky
Failed CI StepsHistory
cc @mrodm |
Run tests using Elastic Agent images where it is possible.
Author's checklist