Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove excessive filter kwarg appearing in AggBase direct aggregation access #1903

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Remove excessive filter kwarg appearing in AggBase direct aggregation access #1903

merged 2 commits into from
Sep 11, 2024

Conversation

rikkt0r
Copy link
Contributor

@rikkt0r rikkt0r commented Sep 6, 2024

Pull request for issue (#1902)

Copy link

cla-checker-service bot commented Sep 6, 2024

💚 CLA has been signed

@rikkt0r rikkt0r marked this pull request as draft September 6, 2024 16:17
@rikkt0r rikkt0r marked this pull request as ready for review September 6, 2024 16:17
@rikkt0r
Copy link
Contributor Author

rikkt0r commented Sep 6, 2024

It'd be great if someone could kick this cla bot to recheck the agreement

@giovannipcarvalho
Copy link

I'm also impacted by the problem this patch solves.

@miguelgrinberg miguelgrinberg added the backport 8.x Backport to 8.x label Sep 11, 2024
@miguelgrinberg miguelgrinberg merged commit b06a222 into elastic:main Sep 11, 2024
17 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 11, 2024
* Remove excessive filter kwarg appearing in AggBase direct aggregation access (#1902)

* Typo (#1902)

(cherry picked from commit b06a222)
miguelgrinberg pushed a commit that referenced this pull request Sep 11, 2024
#1906)

* Remove excessive filter kwarg appearing in AggBase direct aggregation access (#1902)

* Typo (#1902)

(cherry picked from commit b06a222)

Co-authored-by: Grzegorz Wójcicki <rikkt0r@protonmail.ch>
@rikkt0r rikkt0r deleted the fix_aggregation_params branch September 12, 2024 13:19
miguelgrinberg pushed a commit to miguelgrinberg/elasticsearch-dsl-py that referenced this pull request Dec 9, 2024
…ic#1903)

* Remove excessive filter kwarg appearing in AggBase direct aggregation access (elastic#1902)

* Typo (elastic#1902)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 8.x Backport to 8.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants