Skip to content

Remove excessive filter kwarg appearing in AggBase direct aggregation access #1903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Remove excessive filter kwarg appearing in AggBase direct aggregation access #1903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e79b8b
Remove excessive filter kwarg appearing in AggBase direct aggregation…
rikkt0r Sep 6, 2024
fda47ad
Typo (#1902)
rikkt0r Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion elasticsearch_dsl/aggs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ def __getitem__(self, agg_name: str) -> Agg[_R]:
# make sure we're not mutating a shared state - whenever accessing a
# bucket, return a shallow copy of it to be safe
if isinstance(agg, Bucket):
agg = A(agg.name, filter=None, **agg._params)
agg = A(agg.name, **agg._params)
# be sure to store the copy so any modifications to it will affect us
self._params["aggs"][agg_name] = agg

Expand Down
9 changes: 9 additions & 0 deletions tests/test_aggs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,3 +476,12 @@ def test_top_metrics_aggregation() -> None:
assert {
"top_metrics": {"metrics": {"field": "m"}, "sort": {"s": "desc"}}
} == a.to_dict()


def test_bucket_agg_with_filter() -> None:
b = aggs.Filter(query.Terms(something=[1, 2, 3]))

a = aggs.Terms(field="some_field", size=100)
a.bucket("b", b)

assert a.aggs["b"] == a["b"] # a['b'] threw exception before patch #1902
Loading