Precision on GeoSuggestContext Is A Single Value #4091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should only be one value, and not an array. This is based on documentation from v6+ and v7+. elastic#4089
Contributor
Author
|
I don't think you folks have enough build servers :P |
Mpdreamz
approved these changes
Sep 23, 2019
Member
Mpdreamz
left a comment
Mpdreamz
left a comment
There was a problem hiding this comment.
LGTM but we won't be able to backport this in this form to 7.x due to breaking changes.
We'll need a custom json formatter for those branches.
Contributor
|
Thanks for the PR @khalidabuhakmeh 👍 |
Contributor
|
opening a backport for 7.x shortly |
russcam
added a commit
that referenced
this pull request
Sep 29, 2019
Relates: #4091 This commit adds a SerializeAsSingleFormatter<T> to serialize only the first value in the Precision collection for a GeoSuggestContext context mapping for the "completion" field data type. Move the Context mapping related types to the Nest/Mapping/Types/Specialized/Completion directory to disambiguate from the context query types. Deprecate the Neighbors property on IGeoSuggestContext.
Contributor
|
I've opened #4106 to address 7.x |
russcam
added a commit
that referenced
this pull request
Sep 29, 2019
Relates: #4091 This commit removes the Neighbors property from Completion field data type mapping and updates the Precision type to a Union<Distance,int> to match the context suggest query inputs.
russcam
added a commit
that referenced
this pull request
Sep 30, 2019
Relates: #4091 This commit adds a SerializeAsSingleFormatter<T> to serialize only the first value in the Precision collection for a GeoSuggestContext context mapping for the "completion" field data type. Move the Context mapping related types to the Nest/Mapping/Types/Specialized/Completion directory to disambiguate from the context query types. Deprecate the Neighbors property on IGeoSuggestContext.
russcam
added a commit
that referenced
this pull request
Oct 1, 2019
Relates: #4091 This commit adds a SerializeAsSingleFormatter<T> to serialize only the first value in the Precision collection for a GeoSuggestContext context mapping for the "completion" field data type. Move the Context mapping related types to the Nest/Mapping/Types/Specialized/Completion directory to disambiguate from the context query types. Deprecate the Neighbors property on IGeoSuggestContext.
russcam
added a commit
that referenced
this pull request
Oct 3, 2019
Relates: #4091 This commit removes the Neighbors property from Completion field data type mapping and updates the Precision type to a Union<Distance,int>, to match the context suggest query inputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should only be one value, and not an array.
This is based on documentation from v6+ and v7+.
#4089