Skip to content

Conversation

@russcam
Copy link
Contributor

@russcam russcam commented Sep 29, 2019

Relates: #4091

This commit removes the Neighbors property from Completion field data type mapping and updates
the Precision type to a Union<Distance,int> to match the context suggest query inputs.

Does not require backporting to any branches.

Relates: #4091

This commit removes the Neighbors property from Completion field data type mapping and updates
the Precision type to a Union<Distance,int> to match the context suggest query inputs.
@Mpdreamz
Copy link
Member

LGTM but has one test failure:

Tests.CodeStandards.Descriptors.DescriptorMethodsTakingSingleValueTypeShouldBeNullable [FAIL]
  X Tests.CodeStandards.Descriptors.DescriptorMethodsTakingSingleValueTypeShouldBeNullable [161ms]
  Error Message:
   Expected collection to be empty, but found {"precision on method Precision of Nest.GeoSuggestContextDescriptor`1 is not nullable"}.
  Stack Trace:
     at FluentAssertions.Execution.XUnit2TestFramework.Throw(String message) 
   at FluentAssertions.Execution.TestFrameworkProvider.Throw(String message) 
   at FluentAssertions.Execution.DefaultAssertionStrategy.HandleFailure(String message) 
   at FluentAssertions.Execution.AssertionScope.FailWith(Func`1 failReasonFunc) 

@russcam russcam added the v8.0.0 label Oct 1, 2019
@russcam russcam merged commit 1360919 into master Oct 3, 2019
@Mpdreamz Mpdreamz deleted the fix/suggesters branch November 6, 2019 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants