Read closing brace of extended stats aggregation #4118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates: #4109 This commit fixes an issue with extended stats aggregation parsing whereby the closing brace of std_deviation_bounds_as_string is not read when skipping over the object, leading to the reader exiting at this point, resulting in any subsequent aggregations from not being read from the JSON response and added to SearchResponse.Aggregations.
Mpdreamz
approved these changes
Oct 3, 2019
Member
Mpdreamz
left a comment
Mpdreamz
left a comment
There was a problem hiding this comment.
LGTM, added a note about asserting the sum value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates: #4109
This commit fixes an issue with extended stats aggregation parsing whereby the closing brace of std_deviation_bounds_as_string
is not read when skipping over the object, leading to the reader exiting at this point, resulting in any subsequent aggregations
from not being read from the JSON response and added to SearchResponse.Aggregations.