Skip to content

Read closing brace of extended stats aggregation #4118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
russcam merged 2 commits into from
Oct 8, 2019
Merged

Read closing brace of extended stats aggregation #4118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0b0836
Read closing brace of extended stats aggregation
russcam Oct 3, 2019
fc359c1
assert sum aggregation
russcam Oct 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/Nest/Aggregations/AggregateJsonConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,10 +413,11 @@ private IAggregate GetExtendedStatsAggregate(StatsAggregate statsMetric, JsonRea
// std_deviation_bounds is an object, so we need to skip its properties
if (((string)reader.Value).Equals(Parser.StdDeviationBoundsAsString))
{
reader.Read();
reader.Read();
reader.Read();
reader.Read();
reader.Read(); // move to {
reader.Read(); // move to "upper"
reader.Read(); // move to upper date value
reader.Read(); // move to "lower"
reader.Read(); // move to lower date value. Subsequent 2 reads will read closing "std_deviation_bounds_as_string" } and next token
}
reader.Read();
reader.Read();
Expand Down
11 changes: 10 additions & 1 deletion src/Tests/Tests.Reproduce/GitHubIssue4103.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,10 @@ public void CanDeserializeExtendedStats()
""upper"": ""2019-09-26T20:05:53.344Z"",
""lower"": ""2019-09-26T17:56:16.529Z""
}
}
},
""sum"" : {
""value"": 40
}
}
}";

Expand All @@ -66,6 +69,8 @@ public void CanDeserializeExtendedStats()

var response = client.Search<object>(s => s.AllIndices());

response.Aggregations.Count.Should().Be(2);

var extendedStats = response.Aggregations.ExtendedStats("1");
extendedStats.Should().NotBeNull();
extendedStats.Count.Should().Be(3);
Expand All @@ -79,6 +84,10 @@ public void CanDeserializeExtendedStats()
extendedStats.StdDeviationBounds.Should().NotBeNull();
extendedStats.StdDeviationBounds.Upper.Should().Be(1569528353344.9695);
extendedStats.StdDeviationBounds.Lower.Should().Be(1569520576529.0305);

var sum = response.Aggregations.Sum("sum");
sum.Should().NotBeNull();
sum.Value.Should().Be(40);
}
}
}