Skip to content

Added PHP 8.4 Support for Elasticsearch 6.8.x #1420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2025
Merged

Conversation

dakujem
Copy link

@dakujem dakujem commented Jan 10, 2025

This PR goes in line with #1417 to add PHP 8.4 support to the 6.8.x branch.

It fixes a common problem with implicitly nullable parameters being deprecated in PHP 8.4.

The changes are backwards compatible till PHP 7.1 and should be good to go.

Thank you in advance!

Copy link

cla-checker-service bot commented Jan 10, 2025

💚 CLA has been signed

@dakujem
Copy link
Author

dakujem commented Jan 10, 2025

Sorry it was not clear to me at first how I was to sign the CLA, and after clicking the initial button nothing really happened, so I assumed some cookies-related magic and posted the PR... 😳

@dakujem dakujem changed the title 6.8.x Added PHP 8.4 Support for Elasticsearch 6.8.x Jan 10, 2025
@ezimuel ezimuel merged commit f72cae9 into elastic:6.8.x Mar 17, 2025
1 check passed
@ezimuel
Copy link
Contributor

ezimuel commented Mar 17, 2025

@dakujem sorry for my late reply. We do not official support anymore 6.x version of this library but since this is an easy fix and also because we collected another great PR I'm going to release it soon in 6.8.4.

@ezimuel
Copy link
Contributor

ezimuel commented Mar 17, 2025

@dakujem just released 6.8.4, thanks again for this PR and for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants