Upgrade ezimuel/ringphp to 1.3.0 to support React Promise v3 for Elasticsearch 6.8.x
#1430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaelitoP
changed the title
ezimuel/ringphp to 1.2.3 to support React Promise v3 for Elasticsearch 6.8.xezimuel/ringphp to 1.3.0 to support React Promise v3 for Elasticsearch 6.8.x
|
Hi @ezimuel |
|
@MaelitoP I just merged this PR. Can you give me a feedback about the test using |
I'm using a fork at the moment (of 6.8.x branch), and it works well. It'll be great if you can release a new version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the
ezimuel/ringphpdependency from version1.2.2to1.3.0.Changes: ezimuel/ringphp@5e4ee1d
Motivation
The current version of ringphp (1.2.2) enforces a dependency on React Promise ~2.0, which conflicts with projects using React Promise v3.
Thank you in advance!