This repository was archived by the owner on Mar 20, 2023. It is now read-only.
Update the ClientSession to use the new timeout parameter. #79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only
conn_timeout
was being passed toaiohttp.ClientSession
, meaning that any long or query would be interrupted after 5 minutes by the default total timeout of 5 minutes.Additionally the connection timeout does not the original elasticsearch-py API, which specifies that the
timeout
parameter is the global timeout: https://elasticsearch-py.readthedocs.io/en/master/api.html#timeoutThis PR updates the
ClientSession
instantiation to pass thetimeout
value to the global timeout.