Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

Update the ClientSession to use the new timeout parameter. #79

Closed
wants to merge 1 commit into from

Conversation

robhaswell
Copy link

Previously only conn_timeout was being passed to aiohttp.ClientSession, meaning that any long or query would be interrupted after 5 minutes by the default total timeout of 5 minutes.

Additionally the connection timeout does not the original elasticsearch-py API, which specifies that the timeout parameter is the global timeout: https://elasticsearch-py.readthedocs.io/en/master/api.html#timeout

This PR updates the ClientSession instantiation to pass the timeout value to the global timeout.

@cla-checker-service
Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
88e33e2

Please, read and sign the above mentioned agreement if you want to contribute to this project

@robhaswell
Copy link
Author

OK I have signed the CLA.

@sethmlarson
Copy link
Contributor

Thanks for opening this. This functionality has been captured in elastic/elasticsearch-py#1232

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants