Skip to content

Add AIOHttpConnection and [async] extra #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 20, 2020
Merged

Add AIOHttpConnection and [async] extra #1232

merged 5 commits into from
May 20, 2020

Conversation

sethmlarson
Copy link
Contributor

@sethmlarson sethmlarson commented May 14, 2020 •
edited
Loading

Adds the AIOHttpConnection class which uses aiohttp as an HTTP client.

@sethmlarson sethmlarson mentioned this pull request May 14, 2020
Closed
@sethmlarson sethmlarson changed the title Add AIOHttpConnection Add AIOHttpConnection and [async] extra May 14, 2020
@sethmlarson
Copy link
Contributor Author

(CI failure is a failed docker pull, all other tests passed)

danielmitterdorfer
danielmitterdorfer reviewed May 18, 2020
View reviewed changes
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I left one suggestion about response body decoding.

@sethmlarson sethmlarson force-pushed the aiohttp branch 2 times, most recently from 5a86d7d to 4862717 Compare May 20, 2020 12:41
This was referenced May 20, 2020
Closed
Closed
Closed
Closed
Closed
Closed
@sethmlarson sethmlarson merged commit f0db9a4 into master May 20, 2020
@sethmlarson sethmlarson deleted the aiohttp branch May 20, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmitterdorfer danielmitterdorfer danielmitterdorfer left review comments

@vEpiphyte vEpiphyte vEpiphyte left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sethmlarson @danielmitterdorfer @vEpiphyte