[MODEL] Avoid executing search twice; Reuse response in Response#raw_response

[estolfo]

Alternative to #847

[coneybeare]

I think it looks great and would solve my particular issue as well, as long as @response.to_hash actually returns the exact same object as a raw_response would.

[estolfo]

Hi @coneybeare Great! I'm glad it resolves your issue. The #to_hash implementation is here so it will return the exact hash representation. But perhaps you are referring to whether the keys will be identical. If that's the case, I believe they will be because HashWrapper inherits from Hashie::Mash and it looks like nothing is done to remove keys when it is initialized here.

[iridakos]

Hi @coneybeare @estolfo

This implementation still triggers double searches if the raw_response is accessed before the response method.

To overcome this I used the following monkey patch:

module Elasticsearch
  module Model
    module Response
      class Response
        def response
          @response ||= HashWrapper.new(raw_response)
        end

        def raw_response
          @raw_response ||= search.execute!
        end
      end
    end
  end
end

Referring commit: 62e2fae#commitcomment-33515229