Skip to content

[MODEL] Avoid executing search twice; Reuse response in Response#raw_response #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2018
Merged

[MODEL] Avoid executing search twice; Reuse response in Response#raw_response #850

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions elasticsearch-model/lib/elasticsearch/model/response.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def timed_out
# Returns the statistics on shards
#
def shards
@shards ||= HashWrapper.new(raw_response['_shards'])
@shards ||= response['_shards']
end

# Returns a Hashie::Mash of the aggregations
Expand All @@ -76,7 +76,7 @@ def suggestions
end

def raw_response
@raw_response ||= search.execute!
@raw_response ||= @response ? @response.to_hash : search.execute!
end
end
end
Expand Down