Implementation of ODBC's setup API #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The setup API is meant to assist with installation of the driver.
stderr redirect will always work
- prompt_user_config() will pop up a dialog-box for connection config; - prompt_user_overwrite() will confirm with the user that a config is to be overwritten.
builds/.gitignore can get cleaned away, move its content into top .gitignore
- add a DSN to start from; - remove small code duplication in SQLDriverConnect; - change config priorities in ConfigDSN(), as follows (most relevant first): . 00-list received as parameter; . registry values; . defaults.
The values from the registry are read into a static buffer, indexed for each entry into the esodbc_dsn_attrs_st structure. Make sure that the indexing is done only for those values in the Registry that have a correspondence in the structure. Also, use SQLWCHAR explicitely instead of the TCHAR (should be same values for Unicode compilation, but might generate issues later.)
Moved from all-static/all-dynamic to all-static, to simplify code management.
Closed
|
PR merged part of #14. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the two required functions part of the setup API. This API is used for installation and configuration of the ODBC driver and can be implemented as stand-alone library or part of the ODBC driver itself.
For simplicity and inline with other implementations, the functions are implemented in the driver library, in setup.[ch] module.
One function, ConfigDriver() is called by the installer DLL (which is part of OS'es ODBC stack) to "configure" the driver -- have the driver populate the needed registry keys.
The other, ConfigDSN() is called by the administrator program to manage the configurations for the data sources available through the driver.
The GUI associated with the DSN management is left out for now and will be added at a later point (this work is ongoing in parallel).