Split conversion functions into own module #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The setup API is meant to assist with installation of the driver.
stderr redirect will always work
- prompt_user_config() will pop up a dialog-box for connection config; - prompt_user_overwrite() will confirm with the user that a config is to be overwritten.
builds/.gitignore can get cleaned away, move its content into top .gitignore
- add a DSN to start from; - remove small code duplication in SQLDriverConnect; - change config priorities in ConfigDSN(), as follows (most relevant first): . 00-list received as parameter; . registry values; . defaults.
The values from the registry are read into a static buffer, indexed for each entry into the esodbc_dsn_attrs_st structure. Make sure that the indexing is done only for those values in the Registry that have a correspondence in the structure. Also, use SQLWCHAR explicitely instead of the TCHAR (should be same values for Unicode compilation, but might generate issues later.)
Moved from all-static/all-dynamic to all-static, to simplify code management.
- add a few more attributes to SQLGetInfo, some describing SQLGetData extentions - WIP on SQLGetData: set-up the temporary binding-unbinding on the requested column. Since SQLGetData requires no state maintenance except position in the source data, the binding is done with a static ARD; if the column index is lower-or-equal to a constant (128), the ARD will also use a static array of records; otherwise a new array is allocated-freed.
Also: - replace boolean conversion function, delegate that to the long long conversion function; - unify functions transfering SQLWCHAR and SQLCHAR strings to application to minimize code duplication; - build.bat : stop on error and propagate it to script exit; - CMakeLists.txt: add flag for parallel building.
move around the 0-terminator accounting, for better code clarity
- moved respective functions to convert.[ch]
Closed
a static array of 350K proves too large for the default 1MB stack, so allocate it on heap
|
Oh, right, sorry for that (last thing done on a Friday). |
- moved respective functions to convert.[ch]
a static array of 350K proves too large for the default 1MB stack, so allocate it on heap
…rch-sql-odbc into feature/convert_split
|
This PR will now still show the full set of changes, but the diff between the elastic/master and bpintea/convert_split should be available now ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The query.c module contained all the data conversion functions (SQL --> C, for columns --> app, as well as C --> SQL, for app --> parameters). It thus became quite large and hard to navigate.
This PR splits the conversion functions into own module, convert.[ch] and adds some small changes needed for that.