Skip to content

Commit

Permalink
[Transform] add debug log for configuration index (#49484)
Browse files Browse the repository at this point in the history
add debug log for transform creation and disallow partial results for retrieval
  • Loading branch information
Hendrik Muhs authored Nov 25, 2019
1 parent f836754 commit 3a2339f
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
*/
package org.elasticsearch.xpack.transform.action;

import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import org.elasticsearch.ElasticsearchStatusException;
import org.elasticsearch.action.ActionListener;
import org.elasticsearch.action.support.ActionFilters;
Expand Down Expand Up @@ -37,6 +39,8 @@

public class TransportDeleteTransformAction extends TransportMasterNodeAction<Request, AcknowledgedResponse> {

private static final Logger logger = LogManager.getLogger(TransportDeleteTransformAction.class);

private final TransformConfigManager transformConfigManager;
private final TransformAuditor auditor;
private final Client client;
Expand Down Expand Up @@ -102,6 +106,7 @@ protected void masterOperation(Task task, Request request, ClusterState state, A
} else {
ActionListener<Void> stopTransformActionListener = ActionListener.wrap(
stopResponse -> transformConfigManager.deleteTransform(request.getId(), ActionListener.wrap(r -> {
logger.debug("[{}] deleted transform", request.getId());
auditor.info(request.getId(), "Deleted transform.");
listener.onResponse(new AcknowledgedResponse(r));
}, listener::onFailure)),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

package org.elasticsearch.xpack.transform.action;

import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import org.elasticsearch.ElasticsearchStatusException;
import org.elasticsearch.ResourceAlreadyExistsException;
import org.elasticsearch.Version;
Expand Down Expand Up @@ -61,6 +63,8 @@

public class TransportPutTransformAction extends TransportMasterNodeAction<Request, AcknowledgedResponse> {

private static final Logger logger = LogManager.getLogger(TransportPutTransformAction.class);

private final XPackLicenseState licenseState;
private final Client client;
private final TransformConfigManager transformConfigManager;
Expand Down Expand Up @@ -263,6 +267,7 @@ private void putTransform(Request request, ActionListener<AcknowledgedResponse>

// <3> Return to the listener
ActionListener<Boolean> putTransformConfigurationListener = ActionListener.wrap(putTransformConfigurationResult -> {
logger.debug("[{}] created transform", config.getId());
auditor.info(config.getId(), "Created transform.");
listener.onResponse(new AcknowledgedResponse(true));
}, listener::onFailure);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,7 @@ public void getTransformCheckpoint(String transformId, long checkpoint, ActionLi
// use sort to get the last
.addSort("_index", SortOrder.DESC)
.setSize(1)
.setAllowPartialSearchResults(false)
.request();

executeAsyncWithOrigin(
Expand Down Expand Up @@ -293,6 +294,7 @@ public void getTransformConfiguration(String transformId, ActionListener<Transfo
// use sort to get the last
.addSort("_index", SortOrder.DESC)
.setSize(1)
.setAllowPartialSearchResults(false)
.request();

executeAsyncWithOrigin(
Expand Down Expand Up @@ -327,6 +329,7 @@ public void getTransformConfigurationForUpdate(
// use sort to get the last
.addSort("_index", SortOrder.DESC)
.setSize(1)
.setAllowPartialSearchResults(false)
.seqNoAndPrimaryTerm(true)
.request();

Expand Down Expand Up @@ -506,6 +509,7 @@ public void getTransformStoredDoc(
// use sort to get the last
.addSort("_index", SortOrder.DESC)
.setSize(1)
.setAllowPartialSearchResults(false)
.seqNoAndPrimaryTerm(true)
.request();

Expand Down

0 comments on commit 3a2339f

Please sign in to comment.