Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] JdbcDocCsvSpecIT test {docs.testFilterToday} failing #109273

Closed
ChrisHegarty opened this issue Jun 2, 2024 · 6 comments · Fixed by #109274
Closed

[CI] JdbcDocCsvSpecIT test {docs.testFilterToday} failing #109273

ChrisHegarty opened this issue Jun 2, 2024 · 6 comments · Fixed by #109274
Labels
:Analytics/SQL SQL querying Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests >test-failure Triaged test failures from CI

Comments

@ChrisHegarty
Copy link
Contributor

Build scan:
https://gradle-enterprise.elastic.co/s/oz7ndwjtcf3bu/tests/:x-pack:plugin:sql:qa:server:single-node:javaRestTest/org.elasticsearch.xpack.sql.qa.single_node.JdbcDocCsvSpecIT/test%20%7Bdocs.testFilterToday%7D

Reproduction line:

./gradlew ':x-pack:plugin:sql:qa:server:single-node:javaRestTest' --tests "org.elasticsearch.xpack.sql.qa.single_node.JdbcDocCsvSpecIT" -Dtests.method="test {docs.testFilterToday}" -Dtests.seed=6F7F99E69BBFF5FE -Dtests.locale=sl -Dtests.timezone=SystemV/MST7 -Druntime.java=22

Applicable branches:
main

Reproduces locally?:
Didn't try

Failure history:
Failure dashboard for org.elasticsearch.xpack.sql.qa.single_node.JdbcDocCsvSpecIT#test {docs.testFilterToday}

Failure excerpt:

org.junit.ComparisonFailure: Different result for column [first_name], entry [3] expected:<An[neke]> but was:<An[oosh]>

  at __randomizedtesting.SeedInfo.seed([6F7F99E69BBFF5FE:E72BA63C35439806]:0)
  at org.junit.Assert.assertEquals(Assert.java:117)
  at org.elasticsearch.xpack.sql.qa.jdbc.JdbcAssert.doAssertResultSetData(JdbcAssert.java:337)
  at org.elasticsearch.xpack.sql.qa.jdbc.JdbcAssert.assertResultSetData(JdbcAssert.java:227)
  at org.elasticsearch.xpack.sql.qa.jdbc.JdbcAssert.assertResultSets(JdbcAssert.java:104)
  at org.elasticsearch.xpack.sql.qa.single_node.JdbcDocCsvSpecIT.assertResults(JdbcDocCsvSpecIT.java:83)
  at org.elasticsearch.xpack.sql.qa.single_node.JdbcDocCsvSpecIT.doTest(JdbcDocCsvSpecIT.java:93)
  at org.elasticsearch.xpack.sql.qa.jdbc.SpecBaseIntegrationTestCase.test(SpecBaseIntegrationTestCase.java:86)
  at jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
  at java.lang.reflect.Method.invoke(Method.java:580)
  at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.junit.rules.RunRules.evaluate(RunRules.java:20)
  at org.apache.lucene.tests.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:48)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at org.apache.lucene.tests.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
  at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
  at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
  at org.junit.rules.RunRules.evaluate(RunRules.java:20)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:843)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:490)
  at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:955)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:840)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:891)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:902)
  at org.elasticsearch.test.cluster.local.DefaultLocalElasticsearchCluster$1.evaluate(DefaultLocalElasticsearchCluster.java:47)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
  at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
  at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
  at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
  at org.apache.lucene.tests.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
  at org.junit.rules.RunRules.evaluate(RunRules.java:20)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:850)
  at java.lang.Thread.run(Thread.java:1570)

@ChrisHegarty ChrisHegarty added the >test-failure Triaged test failures from CI label Jun 2, 2024
ChrisHegarty added a commit that referenced this issue Jun 2, 2024
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label needs:risk Requires assignment of a risk label (low, medium, blocker) labels Jun 2, 2024
@ChrisHegarty ChrisHegarty added :Analytics/SQL SQL querying Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests and removed needs:triage Requires assignment of a team area label needs:risk Requires assignment of a risk label (low, medium, blocker) labels Jun 3, 2024
@maxhniebergall
Copy link
Contributor

maxhniebergall commented Jun 3, 2024

@ChrisHegarty , will you be backporting this to 7.17? This same problem is causing test failures everywhere.

https://gradle-enterprise.elastic.co/s/6glaulw6dv5xw

@maxhniebergall maxhniebergall reopened this Jun 3, 2024
@jakelandis
Copy link
Contributor

jakelandis commented Jun 3, 2024

I'll fix this on #108330 for 7.17 since it is blocking my PR from being merged and the test fix is trivial.

@jakelandis
Copy link
Contributor

closing this as fixed:
main: #109274
7.17: #108330

@ChrisHegarty
Copy link
Contributor Author

Thanks @jakelandis

@pxsalehi
Copy link
Member

pxsalehi commented Jun 4, 2024

The fix might need to be backported to 8.13. There are a lot of failures: https://es-delivery-stats.elastic.dev/app/r/s/aqFxV

@ChrisHegarty
Copy link
Contributor Author

The fix might need to be backported to 8.13.

Done

jakelandis added a commit that referenced this issue Jun 4, 2024
This reverts commit 4e08df5 (#108330)
This commit also fixes #109273 in 7.17.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/SQL SQL querying Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests >test-failure Triaged test failures from CI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants