Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sql JdbcDocCsvSpecIT test {docs.testFilterToday} failing #109274

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

ChrisHegarty
Copy link
Contributor

@ChrisHegarty ChrisHegarty commented Jun 2, 2024

This commit fixes an SQL test that hardcodes expected results based on today's date. The docs.testFilterToday test needs to be updated since June 2 2024, because Anneke's hire-date of 1989-06-02 (35 years ago as of time of writing) affects the expected output.

closes #109273

@ChrisHegarty ChrisHegarty added >test Issues or PRs that are addressing/adding tests :Analytics/SQL SQL querying Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Jun 2, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@ChrisHegarty
Copy link
Contributor Author

@elasticmachine update branch

@ChrisHegarty
Copy link
Contributor Author

@elasticmachine update branch

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch. Fine for now.

We probably should hard code "now" in the tests for make this not so much a thing.

@ChrisHegarty ChrisHegarty merged commit 89113e9 into elastic:main Jun 3, 2024
15 checks passed
@ChrisHegarty ChrisHegarty deleted the sql_test branch June 3, 2024 07:30
ChrisHegarty added a commit that referenced this pull request Jun 3, 2024
This commit fixes an SQL test that hardcodes expected results based on today's date. The docs.testFilterToday test needs to be updated since June 2 2024, because Anneke's hire-date of 1989-06-02 (35 years ago as of time of writing) affects the expected output.
ChrisHegarty added a commit that referenced this pull request Jun 4, 2024
This commit fixes an SQL test that hardcodes expected results based on today's date. The docs.testFilterToday test needs to be updated since June 2 2024, because Anneke's hire-date of 1989-06-02 (35 years ago as of time of writing) affects the expected output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/SQL SQL querying Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.14.1 v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] JdbcDocCsvSpecIT test {docs.testFilterToday} failing
4 participants