Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GeoWKTShapeParserTests#testParseGeometryCollection fails with an IllegalArgumentException #37894

Closed
jtibshirani opened this issue Jan 26, 2019 · 2 comments
Closed

GeoWKTShapeParserTests#testParseGeometryCollection fails with an IllegalArgumentException #37894

jtibshirani opened this issue Jan 26, 2019 · 2 comments
Assignees
@imotov
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >test-failure Triaged test failures from CI

Comments

@jtibshirani
Copy link
Contributor

jtibshirani commented Jan 26, 2019 •
edited
Loading

This reproduces for me locally with the line below. It seems to only fail on master, and not 6.x.

Link to the build:https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+corretto-periodic/ES_BUILD_JAVA=java11,label=amazon/75/

Command to reproduce:

./gradlew :server:unitTest \
  -Dtests.seed=31C073EB0CC10A18 \
  -Dtests.class=org.elasticsearch.common.geo.GeoWKTShapeParserTests \
  -Dtests.method="testParseGeometryCollection" \
  -Dtests.security.manager=true \
  -Dtests.locale=fr-FR \
  -Dtests.timezone=America/Danmarkshavn \
  -Dcompiler.java=11 \
  -Druntime.java=8

Relevant excerpt from the logs:

ERROR   0.60s | GeoWKTShapeParserTests.testParseGeometryCollection <<< FAILURES!
   > Throwable #1: java.lang.IllegalArgumentException: the list of shapes cannot be null or empty
   >    at __randomizedtesting.SeedInfo.seed([31C073EB0CC10A18:BF67513903E6CFA7]:0)
   >    at org.elasticsearch.geo.geometry.GeometryCollection.<init>(GeometryCollection.java:40)
   >    at org.elasticsearch.common.geo.builders.GeometryCollectionBuilder.buildGeometry(GeometryCollectionBuilder.java:195)
   >    at org.elasticsearch.common.geo.GeoWKTShapeParserTests.testParseGeometryCollection(GeoWKTShapeParserTests.java:441)
   >    at java.lang.Thread.run(Thread.java:748)
@jtibshirani jtibshirani added :Analytics/Geo Indexing, search aggregations of geo points and shapes >test-failure Triaged test failures from CI labels Jan 26, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo

@jtibshirani
Copy link
Contributor Author

I temporarily muted the test in e41ccdc.

jtibshirani added a commit that referenced this issue Jan 26, 2019
@jtibshirani
Mute GeoWKTShapeParserTests#testParseGeometryCollection
e41ccdc 
Tracked in #37894.
jtibshirani added a commit that referenced this issue Jan 26, 2019
@jtibshirani
Mute GeoWKTShapeParserTests#testParseGeometryCollection
256873b 
Tracked in #37894.
@imotov imotov self-assigned this Jan 26, 2019
@imotov imotov mentioned this issue Jan 29, 2019
Merged
imotov added a commit that referenced this issue Jan 30, 2019
@imotov
Geo: Fix Empty Geometry Collection Handling (#37978)
23805fa 
Fixes handling empty geometry collection and re-enables
testParseGeometryCollection test.

Fixes #37894
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imotov imotov

Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@imotov @jtibshirani @elasticmachine