Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geo: Fix Empty Geometry Collection Handling #37978

Merged
merged 1 commit into from
Jan 30, 2019

Conversation

imotov
Copy link
Contributor

@imotov imotov commented Jan 29, 2019

Fixes handling empty geometry collection and re-enables
testParseGeometryCollection test.

Fixes #37894

Fixes handling empty geometry collection and re-enables
testParseGeometryCollection test.
@imotov imotov added >bug :Analytics/Geo Indexing, search aggregations of geo points and shapes >test-failure Triaged test failures from CI v7.0.0 labels Jan 29, 2019
@imotov imotov requested a review from nknize January 29, 2019 15:21
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo

@imotov imotov requested a review from iverase January 29, 2019 20:18
Copy link
Contributor

@iverase iverase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imotov
Copy link
Contributor Author

imotov commented Jan 30, 2019

Thanks for the review @iverase !!!

@imotov imotov removed the request for review from nknize January 30, 2019 14:04
@imotov imotov merged commit 23805fa into elastic:master Jan 30, 2019
jasontedor added a commit to dnhatn/elasticsearch that referenced this pull request Jan 30, 2019
* master:
  Expose retention leases in shard stats (elastic#37991)
  Make primary terms fields private in index shard (elastic#38036)
  ML: Add reason field in JobTaskState (elastic#38029)
  Log flush_stats and commit_stats in testMaybeFlush
  HLRC: Fix strict setting exception handling (elastic#37247)
  Test: Enable strict deprecation on all tests (elastic#36558)
  Removes typed calls from YAML REST tests (elastic#37611)
  Switch default time format for ingest from Joda to Java for v7 (elastic#37934)
  Remove deprecated Plugin#onModule extension points (elastic#37866)
  Geo: Fix Empty Geometry Collection Handling (elastic#37978)
@imotov imotov deleted the issue-37894-fix-empty-collection-test branch May 1, 2020 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >bug >test-failure Triaged test failures from CI v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants