Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing JsonThrowablePatternConverterTests.testStacktraceWithJson #38705

Closed
pgomulka opened this issue Feb 11, 2019 · 1 comment · Fixed by #38771
Closed

Failing JsonThrowablePatternConverterTests.testStacktraceWithJson #38705

pgomulka opened this issue Feb 11, 2019 · 1 comment · Fixed by #38771
Labels
:Core/Infra/Logging Log management and logging utilities >test-failure Triaged test failures from CI v7.0.0-rc1 v7.2.0 v8.0.0-alpha1

Comments

@pgomulka
Copy link
Contributor

pgomulka commented Feb 11, 2019 •
edited
Loading

The test is failing on Windows build machines due to line separator being '\r\n' whereas the test is using just '\n'. Making this platform independent with System.getLineSeparator should help

:server:unitTest -Dtests.seed=10C58ADB9E1F22BD -Dtests.class=org.elasticsearch.common.logging.JsonThrowablePatternConverterTests -Dtests.method="testStacktraceWithJson" -Dtests.security.manager=true -Dtests.locale=mt-MT -Dtests.timezone=Pacific/Port_Moresby -Dcompiler.java=11 -Druntime.java=8

https://build-stats.elastic.co/app/kibana#/discover?_g=(refreshInterval:(pause:!t,value:0),time:(from:now-24h,mode:quick,to:now))&_a=(columns:!(branch,message),filters:!(),index:e58bf320-7efd-11e8-bf69-63c8ef516157,interval:auto,query:(language:kuery,query:%27class.keyword%20:%22org.elasticsearch.common.logging.JsonThrowablePatternConverterTests%22%27),sort:!(time,desc))
@pgomulka pgomulka added >test-failure Triaged test failures from CI v7.0.0 v8.0.0 v7.2.0 labels Feb 11, 2019
@pgomulka pgomulka self-assigned this Feb 11, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@pgomulka pgomulka added the :Core/Infra/Logging Log management and logging utilities label Feb 11, 2019
@pgomulka pgomulka mentioned this issue Feb 11, 2019
Merged
pgomulka added a commit that referenced this issue Feb 11, 2019
@pgomulka
mute Failing tests related to logging and joda-java migration (#38704)
5e71102 
the tests awaits fix from #38693 and #38705 and #38581
pgomulka added a commit to pgomulka/elasticsearch that referenced this issue Feb 11, 2019
@pgomulka
mute Failing tests related to logging and joda-java migration (elasti…
6db7d4e 
…c#38704)

the tests awaits fix from elastic#38693 and elastic#38705 and elastic#38581
@pgomulka pgomulka mentioned this issue Feb 11, 2019
Merged
pgomulka added a commit that referenced this issue Feb 11, 2019
@pgomulka
mute Failing tests related to logging and joda-java migration backport(…
ba9a4d1 
…#38704)(#38710)

the tests awaits fix from #38693 and #38705 and #38581
pgomulka added a commit to pgomulka/elasticsearch that referenced this issue Feb 11, 2019
@pgomulka
mute Failing tests related to logging and joda-java migration (elasti…
4593a7b 
…c#38704)

the tests awaits fix from elastic#38693 and elastic#38705 and elastic#38581
@pgomulka pgomulka mentioned this issue Feb 11, 2019
Merged
pgomulka added a commit that referenced this issue Feb 11, 2019
@pgomulka
mute Failing tests related to logging and joda-java migration(#38713)…
c94d36e 
… backport #38704

the tests awaits fix from #38693 and #38705 and #38581
@pgomulka pgomulka mentioned this issue Feb 11, 2019
Merged
pgomulka added a commit that referenced this issue Feb 11, 2019
@pgomulka
reenable the test with more debugging info (#38721)
8bd5850 
reenable the test with more debugging info
relates #38705
@pgomulka pgomulka mentioned this issue Feb 12, 2019
Merged
pgomulka added a commit that referenced this issue Feb 12, 2019
@pgomulka
Fix line separators in JSON logging tests (#38771)
782eb0a 
The hardcoded '\n' in string will not work in Windows where there is a
different line separator. A System.lineSeparator should be used to make
it work on all platforms
closes #38705
pgomulka added a commit that referenced this issue Feb 12, 2019
@pgomulka
Format Watcher.status.lastChecked and lastMetCondition (#38790) backp…
ae1b2ba 
…ort#38626

The hardcoded '\n' in string will not work in Windows where there is a
different line separator. A System.lineSeparator should be used to make
it work on all platforms
closes #38705
backport #38626
pgomulka added a commit to pgomulka/elasticsearch that referenced this issue Feb 13, 2019
@pgomulka
Fix line separators in JSON logging tests (elastic#38771)
193a7fd 
The hardcoded '\n' in string will not work in Windows where there is a
different line separator. A System.lineSeparator should be used to make
it work on all platforms
closes elastic#38705
pgomulka added a commit to pgomulka/elasticsearch that referenced this issue Feb 13, 2019
@pgomulka
Fix line separators in JSON logging tests (elastic#38771)
270363b 
The hardcoded '\n' in string will not work in Windows where there is a
different line separator. A System.lineSeparator should be used to make
it work on all platforms
closes elastic#38705
This was referenced Feb 13, 2019
Merged
Merged
pgomulka added a commit that referenced this issue Feb 13, 2019
@pgomulka
Fix line separators in JSON logging tests backport#38771 #38834
7404882 
The hardcoded '\n' in string will not work in Windows where there is a
different line separator. A System.lineSeparator should be used to make
it work on all platforms
closes #38705 
backport #38771
pgomulka added a commit that referenced this issue Feb 13, 2019
@pgomulka
Fix line separators in JSON logging tests backport#38771 (#38833)
dc0af84 
The hardcoded '\n' in string will not work in Windows where there is a
different line separator. A System.lineSeparator should be used to make
it work on all platforms
closes #38705 
backport #38771
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Core/Infra/Logging Log management and logging utilities >test-failure Triaged test failures from CI v7.0.0-rc1 v7.2.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix line separators in JSON logging tests pgomulka/elasticsearch
4 participants
@jakelandis @michaelbaamonde @pgomulka @elasticmachine