Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable JsonThrowablePatternConverterTests with more debug #38721

Merged
merged 1 commit into from
Feb 11, 2019
Merged

Enable JsonThrowablePatternConverterTests with more debug #38721

merged 1 commit into from
Feb 11, 2019

Conversation

pgomulka
Copy link
Contributor

reenable the test with more debugging info
relates #38705

@pgomulka pgomulka added >test-failure Triaged test failures from CI :Core/Infra/Logging Log management and logging utilities v8.0.0 labels Feb 11, 2019
@pgomulka pgomulka self-assigned this Feb 11, 2019
@pgomulka pgomulka requested a review from alpar-t February 11, 2019 13:33
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

alpar-t
alpar-t approved these changes Feb 11, 2019
View reviewed changes
Copy link
Contributor

@alpar-t alpar-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
It's unfortunate we don't have a way to get the debug info without a build failure.
I tried to reproduce on a VM running a CI image but was not able to.

@pgomulka pgomulka merged commit 8bd5850 into elastic:master Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alpar-t alpar-t alpar-t approved these changes

Assignees
No one assigned
Labels
:Core/Infra/Logging Log management and logging utilities >test-failure Triaged test failures from CI v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pgomulka @elasticmachine @alpar-t @jakelandis