Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation info API reports a warning for a setting that should be ignored #82889

Closed
masseyke opened this issue Jan 20, 2022 · 2 comments
Closed

Deprecation info API reports a warning for a setting that should be ignored #82889

masseyke opened this issue Jan 20, 2022 · 2 comments
Labels
blocker >bug Team:Data Management Meta label for data/management team v7.17.0

Comments

@masseyke
Copy link
Member

masseyke commented Jan 20, 2022 •
edited
Loading

If a setting is specified by deprecation.skip_deprecated_settings then the deprecation info API is supposed to avoid reporting warnings for that setting. However if one of the settings specified by deprecation.skip_deprecated_settings is set dynamically then the deprecation info API will still report it.
This bug was caused by #82487. Previously we were not checking cluster (dynamic) settings at all in NodeDeprecationChecks. We had added support for respecting deprecation.skip_deprecated_settings in the deprecation logger (not deprecation info API) for dynamic settings in #81836. The ticket where deprecation.skip_deprecated_settings was originally introduced is #78725.
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Jan 20, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@masseyke masseyke mentioned this issue Jan 20, 2022
Merged
@masseyke masseyke removed the needs:triage Requires assignment of a team area label label Jan 20, 2022
masseyke added a commit that referenced this issue Jan 20, 2022
@masseyke
Ignoring dynamic settings specified by deprecation.skip_deprecated_se…
408dc51 
…ttings in node deprecation checks (#82883)

This commit makes it so that the NodeDeprecationChecks part of the deprecation info API will ignore settings
specified by deprecation.skip_deprecated_settings, even if those settings are dynamically set.
Closes #82889
@jakelandis
Copy link
Contributor

closed by #82883

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocker >bug Team:Data Management Meta label for data/management team v7.17.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@masseyke @jakelandis @elasticmachine