Change deprecation.skip_deprecated_settings to work with dynamic settings #81836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakrone
reviewed
Dec 16, 2021
Comment on lines
62
to
63
| public static void setInitialEnvironmentSettings(Settings settings) { | ||
| initialEnvironment = settings; |
There was a problem hiding this comment.
Super minor, but we call these "nodeSettings" in a few places to distinguish them from generic Settings objects, might help clarify here (as well as adding javadoc)
Comment on lines
105
to
107
| List<String> skipTheseDeprecations = initialEnvironment == null | ||
| ? Collections.emptyList() | ||
| : initialEnvironment.getAsList("deprecation.skip_deprecated_settings"); |
There was a problem hiding this comment.
Rather than re-create this list every time, and since we were planning on removing the dynamic property from deprecation.skip_deprecated_settings (since it's not really dynamic), can we just calculate the List<String> inside of setInitialEnvironmentSettings and then not have to calculate it for every log message?
| @@ -325,6 +325,7 @@ protected Node( | |||
| final List<Closeable> resourcesToClose = new ArrayList<>(); // register everything we need to release in the case of an error | |||
| boolean success = false; | |||
| try { | |||
| DeprecationLogger.setInitialEnvironmentSettings(initialEnvironment.settings()); | |||
There was a problem hiding this comment.
I think a comment about what this line is for would be very helpful
|
@elasticsearchmachine update branch |
jakelandis
approved these changes
Dec 17, 2021
masseyke
deleted the
fix/allow-hiding-deprecations-of-dynamic-settings
branch
|
Closes #81700 |
elasticmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Relates #78725 |
albertzaharovits
changed the title
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Mar 1, 2022
…tings (elastic#81836) Previously, deprecation.skip_deprecated_settings did not work with dynamic settings. The reason is that when the deprecation check was done, only the current settings were available. When the setting is a node setting that is fine because deprecation.skip_deprecated_settings is also a node setting. However when the setting is dynamic, deprecation.skip_deprecated_settings is not in the Settings object.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 1, 2022
…tings (#81836) (#84523) Previously, deprecation.skip_deprecated_settings did not work with dynamic settings. The reason is that when the deprecation check was done, only the current settings were available. When the setting is a node setting that is fine because deprecation.skip_deprecated_settings is also a node setting. However when the setting is dynamic, deprecation.skip_deprecated_settings is not in the Settings object.
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Mar 1, 2022
…tings (elastic#81836) (elastic#84523) Previously, deprecation.skip_deprecated_settings did not work with dynamic settings. The reason is that when the deprecation check was done, only the current settings were available. When the setting is a node setting that is fine because deprecation.skip_deprecated_settings is also a node setting. However when the setting is dynamic, deprecation.skip_deprecated_settings is not in the Settings object.
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Mar 1, 2022
…tings (elastic#81836) (elastic#84523) Previously, deprecation.skip_deprecated_settings did not work with dynamic settings. The reason is that when the deprecation check was done, only the current settings were available. When the setting is a node setting that is fine because deprecation.skip_deprecated_settings is also a node setting. However when the setting is dynamic, deprecation.skip_deprecated_settings is not in the Settings object.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 1, 2022
…tings (#81836) (#84523) (#84527) Previously, deprecation.skip_deprecated_settings did not work with dynamic settings. The reason is that when the deprecation check was done, only the current settings were available. When the setting is a node setting that is fine because deprecation.skip_deprecated_settings is also a node setting. However when the setting is dynamic, deprecation.skip_deprecated_settings is not in the Settings object.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 1, 2022
…tings (#81836) (#84523) (#84526) Previously, deprecation.skip_deprecated_settings did not work with dynamic settings. The reason is that when the deprecation check was done, only the current settings were available. When the setting is a node setting that is fine because deprecation.skip_deprecated_settings is also a node setting. However when the setting is dynamic, deprecation.skip_deprecated_settings is not in the Settings object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, deprecation.skip_deprecated_settings did not work with dynamic settings. The reason is that when
the deprecation check was done, only the current settings were available. When the setting is a node setting that is
fine because deprecation.skip_deprecated_settings is also a node setting. However when the setting is dynamic,
deprecation.skip_deprecated_settings is not in the Settings object.