Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes reading of CORS pre-flight headers and methods #17524

Closed

Conversation

abeyad
Copy link

@abeyad abeyad commented Apr 5, 2016

CORS headers and methods config parameters must be read as arrays. This
commit fixes the issue. It affects http.cors.allow-methods and
http.cors.allow-headers.

Backports #17523

CORS headers and methods config parameters must be read as arrays. This
commit fixes the issue. It affects http.cors.allow-methods and
http.cors.allow-headers.

Backports elastic#17523
@skundrik
Copy link

skundrik commented Apr 5, 2016

Fixes #17483 Problems with http.cors.allow-methods

abeyad pushed a commit that referenced this pull request Apr 7, 2016
CORS headers and methods config parameters must be read as arrays. This
commit fixes the issue. It affects http.cors.allow-methods and
http.cors.allow-headers.

Closes #17524
Backports #17523
@abeyad
Copy link
Author

abeyad commented Apr 7, 2016

Closed by Commit 1ecc627

@abeyad abeyad closed this Apr 7, 2016
@uschindler
Copy link
Contributor

Thanks for fixing. I have seen the same on my server. But I was able to fix with reverse proxy, so I did not care too much.

In my case the issue came from the fact that I only allowed GET and POST in my configuration.

I will try 2.3.2 and report if it's fixed.

@abeyad
Copy link
Author

abeyad commented Apr 18, 2016

@uschindler Thank you!

@uschindler
Copy link
Contributor

I can confirm: 2.3.2 works again without reverse proxy hack

@abeyad
Copy link
Author

abeyad commented Apr 26, 2016

@uschindler Great, thanks for confirming

@ieatbytes
Copy link

can you please guide me what to write in elasticsearch.yml? i used to work like
network.host: 0.0.0.0 and it was working like charm

@abeyad
Copy link
Author

abeyad commented Jun 13, 2016

@ieatbytes I am not sure what you mean? None of the properties in elasticsearch.yml related to CORS handling have changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Core/Infra/REST API REST infrastructure and utilities v2.3.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants