Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] change wait_for_completion default according to docs #23672

Merged
merged 1 commit into from
Mar 22, 2017
Merged

[API] change wait_for_completion default according to docs #23672

merged 1 commit into from
Mar 22, 2017

Conversation

honzakral
Copy link
Contributor

nik9000
nik9000 approved these changes Mar 21, 2017
View reviewed changes
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this one is wrong then update_by_query and delete_by_query might also be wrong.

@honzakral honzakral force-pushed the rest-api-spec-reindex branch from 8fb7548 to bde37a3 Compare March 21, 2017 12:28
@honzakral
Copy link
Contributor Author

good catch @nik9000, updated the commit to include those APIs

@nik9000
Copy link
Member

nik9000 commented Mar 21, 2017

good catch @nik9000, updated the commit to include those APIs

LGTM. Thanks for fixing my mistake.

1 similar comment
@nik9000
Copy link
Member

nik9000 commented Mar 21, 2017

good catch @nik9000, updated the commit to include those APIs

LGTM. Thanks for fixing my mistake.

@colings86 colings86 added >bug >test Issues or PRs that are addressing/adding tests v5.3.0 v5.4.0 v6.0.0-alpha1 labels Mar 21, 2017
@honzakral honzakral merged commit c7f5c98 into elastic:5.x Mar 22, 2017
honzakral added a commit that referenced this pull request Mar 22, 2017
@honzakral
[API] change wait_for_completion defaults according to docs (#23672)
f8b7ec2
honzakral added a commit that referenced this pull request Mar 22, 2017
@honzakral
[API] change wait_for_completion defaults according to docs (#23672)
5bfaa49
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Mar 22, 2017
@jasontedor
Merge branch 'master' into translog-generation
7480faf 
* master:
  [API] change wait_for_completion defaults according to docs (elastic#23672)
  Share XContent rendering code in terms aggs (elastic#23680)
  Update ingest-node.asciidoc
  [DOCS] Update the docs about the fact that global ordinals for _parent field are loaded eagerly instead of lazily by default.
  Build: remove progress logger hack for gradle 2.13 (elastic#23679)
  Test: Add dump of integ test cluster logs on failure (elastic#23688)
  Plugins: Add plugin cli specific exit codes (elastic#23599)
  Plugins: Output better error message when existing plugin is incompatible (elastic#23562)
  Reindex: wait for cleanup before responding (elastic#23677)
  Packaging: Remove classpath ordering hack (elastic#23596)
  Docs: Add note about updating plugins requiring removal and reinstallation (elastic#23597)
  Build: Make plugin list for smoke tester dynamic (elastic#23601)
  [TEST] Propertly cleans up failing restore test
@clintongormley clintongormley added the :Core/Infra/REST API REST infrastructure and utilities label Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nik9000 nik9000 nik9000 approved these changes

Assignees
No one assigned
Labels
>bug :Core/Infra/REST API REST infrastructure and utilities >test Issues or PRs that are addressing/adding tests v5.3.0 v5.4.0 v6.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@honzakral @nik9000 @clintongormley @colings86