Make reindex wait for cleanup before responding #23677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes reindex and friends to wait until the entire request has been "cleaned up" before responding. "Clean up" in this context is clearing the scroll and (for reindex-from-remote) shutting down the client. Failures to clean up are still only logged, not returned to the user. Closes elastic#23653
tlrx
approved these changes
Mar 21, 2017
| @@ -113,8 +113,9 @@ public void onFailure(Exception e) { | |||
| } | |||
|
|
|||
| @Override | |||
| protected void cleanup() { | |||
| protected void cleanup(Runnable onCompletion) { | |||
| // Nothing to do | |||
|
Thanks @tlrx ! |
nik9000
added a commit
that referenced
this pull request
Mar 21, 2017
Changes reindex and friends to wait until the entire request has been "cleaned up" before responding. "Clean up" in this context is clearing the scroll and (for reindex-from-remote) shutting down the client. Failures to clean up are still only logged, not returned to the user. Closes #23653
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Mar 22, 2017
* master: [API] change wait_for_completion defaults according to docs (elastic#23672) Share XContent rendering code in terms aggs (elastic#23680) Update ingest-node.asciidoc [DOCS] Update the docs about the fact that global ordinals for _parent field are loaded eagerly instead of lazily by default. Build: remove progress logger hack for gradle 2.13 (elastic#23679) Test: Add dump of integ test cluster logs on failure (elastic#23688) Plugins: Add plugin cli specific exit codes (elastic#23599) Plugins: Output better error message when existing plugin is incompatible (elastic#23562) Reindex: wait for cleanup before responding (elastic#23677) Packaging: Remove classpath ordering hack (elastic#23596) Docs: Add note about updating plugins requiring removal and reinstallation (elastic#23597) Build: Make plugin list for smoke tester dynamic (elastic#23601) [TEST] Propertly cleans up failing restore test
This was referenced Mar 28, 2017
|
@nik9000 the |
lcawl
added
:Distributed Indexing/CRUD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes reindex and friends to wait until the entire request has
been "cleaned up" before responding. "Clean up" in this context
is clearing the scroll and (for reindex-from-remote) shutting
down the client. Failures to clean up are still only logged, not
returned to the user.
Closes #23653