Skip to content

Conversation

@javanna
Copy link
Member

@javanna javanna commented Jun 16, 2017

Relates to #24515

@javanna javanna added :Data Management/Indices APIs APIs to create and manage indices and templates >breaking review v6.0.0 labels Jun 16, 2017
@dakrone dakrone self-requested a review June 16, 2017 17:26
@dakrone dakrone removed their assignment Jun 16, 2017
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this LGTM, thanks @javanna!

@javanna
Copy link
Member Author

javanna commented Jun 19, 2017

retest this please

@javanna javanna force-pushed the enhancement/remove_plus_index branch from 792e443 to 5dca3f4 Compare June 19, 2017 09:12
@olcbean
Copy link
Contributor

olcbean commented Jun 19, 2017

Hey @javanna, looks like this change is addressing #5341 as well. Or is there another usecase in which '+' should be supported in the path?

@javanna
Copy link
Member Author

javanna commented Jun 19, 2017

hi @olcbean '+' is still a valid character in index and alias names, just not in their first character. So I'm afraid #5341 is still a valid issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>breaking :Data Management/Indices APIs APIs to create and manage indices and templates v6.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants