Add documentation for JSON fields. #35281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtibshirani
added
>docs
|
Pinging @elastic/es-search-aggs |
jtibshirani
force-pushed
the
json-field-docs
branch
4 times, most recently
from
d4184d2
to
1d79ad2
Compare
colings86
reviewed
Nov 6, 2018
| The `json` mapping type allows an entire JSON object to be indexed as a single field, with support for simple | ||
| queries on the field's contents. A `json` field can be useful for modelling objects with a large number of | ||
| distinct subfields whose keys are not known in advance. This type of situation might arise arise when | ||
| some data is generated directly by users, or by an external third-party application. |
There was a problem hiding this comment.
I think it would be useful to explain a bit more about the trade offs of using this vs explicitly mapping the object. For example one advantage of this is that we expect the resulting index to be smaller with the disadvantage of limited query support and no support for aggregations and sorting.
There was a problem hiding this comment.
Makes a lot of sense, I'll expand this section.
|
|
||
| Leaf values longer than this limit will not be indexed. Defaults to the maximum integer value | ||
| `2147483647` so that no values are skipped. Note that this limit applies to the leaf values | ||
| within the JSON field, and not the length of the entire field. |
There was a problem hiding this comment.
Maybe we should just state that the default is to not skip values of any length rather than mentioning the explicit value here?
There was a problem hiding this comment.
Will fix, I copied this over from the keyword documentation but reading it over again it is quite strange!
11 tasks
jtibshirani
force-pushed
the
object-fields
branch
from
e4ee31c
to
2ffb459
Compare
jtibshirani
force-pushed
the
json-field-docs
branch
from
1d79ad2
to
27fd00e
Compare
|
@colings86 I think this is ready for another look. |
jtibshirani
force-pushed
the
json-field-docs
branch
from
27fd00e
to
87b8ce5
Compare
colings86
approved these changes
Nov 8, 2018
nik9000
reviewed
Nov 8, 2018
| } | ||
| -------------------------------- | ||
| // CONSOLE | ||
|
|
There was a problem hiding this comment.
It might be better to mark this // TESTSETUP then you don't need to mark the others // TEST[continued].
|
@elasticmachine run sample packaging tests |
|
@elasticmachine run gradle build tests |
jtibshirani
force-pushed
the
object-fields
branch
from
e7613b7
to
4c46b07
Compare
After writing tests for all the query types, I noticed these positional queries will actually not work.
jtibshirani
force-pushed
the
json-field-docs
branch
from
d94bf2a
to
03e0008
Compare
jtibshirani
added a commit
to jtibshirani/elasticsearch
that referenced
this pull request
Nov 9, 2018
* Add documentation for JSON fields.
jtibshirani
added a commit
that referenced
this pull request
Nov 30, 2018
* Add documentation for JSON fields.
jtibshirani
added a commit
that referenced
this pull request
Dec 5, 2018
* Add documentation for JSON fields.
jtibshirani
added a commit
that referenced
this pull request
Dec 13, 2018
* Add documentation for JSON fields.
jtibshirani
added a commit
that referenced
this pull request
Mar 6, 2019
* Add documentation for JSON fields.
jtibshirani
added a commit
that referenced
this pull request
Mar 7, 2019
* Add documentation for JSON fields.
jtibshirani
added a commit
that referenced
this pull request
Mar 9, 2019
* Add documentation for JSON fields.
jtibshirani
added a commit
that referenced
this pull request
Mar 11, 2019
* Add documentation for JSON fields.
jtibshirani
added a commit
that referenced
this pull request
Mar 14, 2019
* Add documentation for JSON fields.
jtibshirani
added a commit
that referenced
this pull request
Mar 19, 2019
* Add documentation for JSON fields.
jtibshirani
added a commit
to jtibshirani/elasticsearch
that referenced
this pull request
Mar 19, 2019
* Add documentation for JSON fields.
jtibshirani
added a commit
that referenced
this pull request
Mar 28, 2019
* Add documentation for JSON fields.
jtibshirani
added a commit
that referenced
this pull request
Apr 10, 2019
* Add documentation for JSON fields.
jtibshirani
added a commit
that referenced
this pull request
Apr 17, 2019
* Add documentation for JSON fields.
jtibshirani
added a commit
that referenced
this pull request
May 1, 2019
* Add documentation for JSON fields.
jtibshirani
added a commit
that referenced
this pull request
May 24, 2019
* Add documentation for JSON fields.
jtibshirani
added a commit
that referenced
this pull request
May 29, 2019
* Add documentation for JSON fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.