Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for JSON fields. #35281

Merged
merged 7 commits into from
Nov 9, 2018
Merged

Add documentation for JSON fields. #35281

merged 7 commits into from
Nov 9, 2018

Commits on Nov 8, 2018

  1. Add documentation for JSON fields.

    @jtibshirani
    jtibshirani committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    784437e View commit details
    Browse the repository at this point in the history

  2. Avoid mentioning the maximum integer value when documenting ignore_ab… 

    …ove.
    @jtibshirani
    jtibshirani committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    d5ba785 View commit details
    Browse the repository at this point in the history

  3. Remove 'match phrase' from the list of supported queries. 

    After writing tests for all the query types, I noticed these positional
queries will actually not work.
    @jtibshirani
    jtibshirani committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    9032994 View commit details
    Browse the repository at this point in the history

  4. Explain the trade-offs between JSON fields and the default mapping be… 

    …havior.
    @jtibshirani
    jtibshirani committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    86df1a3 View commit details
    Browse the repository at this point in the history

  5. Wrap line lengths to 80 characters.

    @jtibshirani
    jtibshirani committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    5554bf6 View commit details
    Browse the repository at this point in the history

  6. Remove duplicate phrase.

    @jtibshirani
    jtibshirani committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    717beb7 View commit details
    Browse the repository at this point in the history

  7. Make sure to use TESTSETUP for populating the index.

    @jtibshirani
    jtibshirani committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    03e0008 View commit details
    Browse the repository at this point in the history