Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add basic REST test for geohash_grid #37996

Merged
merged 4 commits into from
Feb 5, 2019
Merged

Conversation

talevy
Copy link
Contributor

@talevy talevy commented Jan 29, 2019

this PR is a part of the general initiative to get more REST coverage in aggregations: #26220

@talevy talevy added >test Issues or PRs that are addressing/adding tests :Analytics/Geo Indexing, search aggregations of geo points and shapes labels Jan 29, 2019
@talevy talevy requested a review from polyfractal January 29, 2019 22:55
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo

@colings86
Copy link
Contributor

Please could you merge this after #37611 to avoid us having to do another iteration on that large PR?

@colings86
Copy link
Contributor

#37611 is now merged

@talevy
Copy link
Contributor Author

talevy commented Jan 30, 2019

awesome! last thing I would have wanted was to make that PR more of a headache
than it looks like it already was! thanks Colin

@talevy talevy added the v7.0.0 label Feb 5, 2019
Copy link
Contributor

@polyfractal polyfractal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

If you're feeling extra motivated we could add a test for illegal precision values, to verify the exception

@talevy talevy merged commit ae47c02 into elastic:master Feb 5, 2019
@talevy talevy deleted the rest-geohash branch February 5, 2019 17:44
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 5, 2019
* master: (23 commits)
  Lift retention lease expiration to index shard (elastic#38380)
  Make Ccr recovery file chunk size configurable (elastic#38370)
  Prevent CCR recovery from missing documents (elastic#38237)
  re-enables awaitsfixed datemath tests (elastic#38376)
  Types removal fix FullClusterRestartIT warnings (elastic#38445)
  Make sure to reject mappings with type _doc when include_type_name is false. (elastic#38270)
  Updates the grok patterns to be consistent with logstash (elastic#27181)
  Ignore type-removal warnings in XPackRestTestHelper (elastic#38431)
  testHlrcFromXContent() should respect assertToXContentEquivalence() (elastic#38232)
  add basic REST test for geohash_grid (elastic#37996)
  Remove DiscoveryPlugin#getDiscoveryTypes (elastic#38414)
  Fix the clock resolution to millis in GetWatchResponseTests (elastic#38405)
  Throw AssertionError when no master (elastic#38432)
  `if_seq_no` and `if_primary_term` parameters aren't wired correctly in REST Client's CRUD API (elastic#38411)
  Enable CronEvalToolTest.testEnsureDateIsShownInRootLocale (elastic#38394)
  Fix failures in BulkProcessorIT#testGlobalParametersAndBulkProcessor. (elastic#38129)
  SQL: Implement CURRENT_DATE (elastic#38175)
  Mute testReadRequestsReturnLatestMappingVersion (elastic#38438)
  [ML] Report index unavailable instead of waiting for lazy node (elastic#38423)
  Update Rollup Caps to allow unknown fields (elastic#38339)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >test Issues or PRs that are addressing/adding tests v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants