Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL: Move metrics tracking inside PlanExecutor #38259

Merged
merged 3 commits into from
Feb 3, 2019
Merged

Conversation

costin
Copy link
Member

@costin costin commented Feb 2, 2019

Move metrics in one place, from the transport layer inside the
PlanExecutor

Close #38258

Move metrics in one place, from the transport layer inside the
PlanExecutor

Close elastic#38258
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Btw, Can you remove the org.elasticsearch.xpack.sql.qa.QueryMetric? Seems unused.

@costin costin merged commit a088155 into elastic:master Feb 3, 2019
costin added a commit to costin/elasticsearch that referenced this pull request Feb 3, 2019
Move metrics in one place, from the transport layer inside the
PlanExecutor
Remove unused class

Close elastic#38258

(cherry picked from commit a088155)
costin added a commit that referenced this pull request Feb 4, 2019
Move metrics in one place, from the transport layer inside the
PlanExecutor
Remove unused class

Close #38258

(cherry picked from commit a088155)
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 4, 2019
…round-sync-6.x

* elastic/6.x:
  Fix testRestoreIncreasesPrimaryTerms on 6.x (elastic#38314)
  SQL: Remove exceptions from Analyzer (elastic#38260) (elastic#38287)
  SQL: Move metrics tracking inside PlanExecutor (elastic#38259) (elastic#38288)
  Backport of elastic#38311: Move TokenService to seqno powered cas
  Handle scheduler exceptions (elastic#38183)
  Mute MlMigrationFullClusterRestartIT#testMigration (elastic#38316)
  6.x Backport of elastic#38278: Move ML Optimistic Concurrency Control to Seq No
  Cleanup construction of interceptors (elastic#38296)
  Throw if two inner_hits have the same name (elastic#37645) (elastic#38194)
  AsyncTwoPhaseIndexerTests race condition fixed elastic#38195 Backport#37830
  Enable SSL in reindex with security QA tests (elastic#38293)
  Ensure ILM policies run safely on leader indices  (elastic#38140)
  Introduce ssl settings to reindex from remote (elastic#38292)
  Fix ordering problem in add or renew lease test (elastic#38281)
  Mute ReplicationTrackerRetentionLeaseTests#testAddOrRenewRetentionLease (elastic#38276)
  Fix NPE in Logfile Audit Filter (elastic#38120) (elastic#38271)
  Enable trace log in FollowerFailOverIT (elastic#38148)
  SQL: Generate relevant error message when grouping functions are not used in GROUP BY (elastic#38017)
@costin costin deleted the fix-38258 branch July 6, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants