Fix: added missing skip #41492
Merged
Fix: added missing skip #41492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-core-infra |
DaveCTurner
requested changes
Apr 24, 2019
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
Good catch @delvedor; however the build is failing due to a syntax error in this change:
ParsingException[Error parsing test named [Copy settings during split index]]; nested: IllegalArgumentException[Expected [START_OBJECT, found [VALUE_NULL], the skip section is not properly indented];
Contributor
|
@elasticmachine please run elasticsearch-ci/1 |
Contributor
|
Discovered while backporting that this had been there but was removed by accident in #41165. I checked that change in detail and couldn't see any other cases that needed this fix. |
Member
Author
|
Great, thank you @DaveCTurner! |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Apr 27, 2019
…ble-map-v1 * elastic/master: Adjust bwc version (elastic#41099) Fix multi-node parsing in voting config exclusions REST API (elastic#41588) Add missing skip: arbitrary_key (elastic#41492) [ML] cleanup + adding description field to transforms (elastic#41554)
akhil10x5
pushed a commit
to akhil10x5/elasticsearch
that referenced
this pull request
May 2, 2019
In `indices.split/30_copy_settings.yml` we are using the `arbitrary_key` feature, but it is not declared inside the skip list.
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
In `indices.split/30_copy_settings.yml` we are using the `arbitrary_key` feature, but it is not declared inside the skip list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
indices.split/30_copy_settings.ymlwe are using thearbitrary_keyfeature, but it is not declared inside the skip list.Related: #40052
/cc @elastic/es-clients