Fix multi-node parsing in voting config exclusions REST API #41588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-napoleon
added
:Distributed Coordination/Cluster Coordination
Collaborator
|
Pinging @elastic/es-distributed |
Member
|
@barkbay I added the 7.1.0 label on the assumption that you intend to backport this. If you end up not backporting for some reason, please remove that label. |
ywelsch
reviewed
Apr 26, 2019
Contributor
ywelsch
left a comment
ywelsch
left a comment
There was a problem hiding this comment.
Good catch, and thank you for the PR. Can you also add the following test to Zen2RestApiIT?
public void testRemoveTwoNodesAtOnce() throws Exception {
internalCluster().setBootstrapMasterNodeIndex(2);
List<String> nodes = internalCluster().startNodes(3);
ensureStableCluster(3);
RestClient restClient = getRestClient();
Response response = restClient.performRequest(new Request("POST", "/_cluster/voting_config_exclusions/" +
nodes.get(2) + "," + nodes.get(0)));
assertThat(response.getStatusLine().getStatusCode(), is(200));
assertThat(response.getEntity().getContentLength(), is(0L));
internalCluster().stopRandomNode(InternalTestCluster.nameFilter(nodes.get(0)));
internalCluster().stopRandomNode(InternalTestCluster.nameFilter(nodes.get(2)));
ensureStableCluster(1);
}
...ain/java/org/elasticsearch/rest/action/admin/cluster/RestAddVotingConfigExclusionAction.java
Outdated
Show resolved
Hide resolved
ywelsch
reviewed
Apr 26, 2019
...ain/java/org/elasticsearch/rest/action/admin/cluster/RestAddVotingConfigExclusionAction.java
Outdated
Show resolved
Hide resolved
Contributor
|
@elasticmachine run elasticsearch-ci/packaging-sample |
ywelsch
approved these changes
Apr 27, 2019
Contributor
ywelsch
left a comment
ywelsch
left a comment
There was a problem hiding this comment.
LGTM. The packaging test failures are unrelated to this PR.
ywelsch
changed the title
ywelsch
pushed a commit
that referenced
this pull request
Apr 27, 2019
Fixes an issue where multiple nodes where not properly parsed in the voting config exclusions REST API. Closes #41587
ywelsch
pushed a commit
that referenced
this pull request
Apr 27, 2019
Fixes an issue where multiple nodes where not properly parsed in the voting config exclusions REST API. Closes #41587
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Apr 27, 2019
…ble-map-v1 * elastic/master: Adjust bwc version (elastic#41099) Fix multi-node parsing in voting config exclusions REST API (elastic#41588) Add missing skip: arbitrary_key (elastic#41492) [ML] cleanup + adding description field to transforms (elastic#41554)
akhil10x5
pushed a commit
to akhil10x5/elasticsearch
that referenced
this pull request
May 2, 2019
…41588) Fixes an issue where multiple nodes where not properly parsed in the voting config exclusions REST API. Closes elastic#41587
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
…41588) Fixes an issue where multiple nodes where not properly parsed in the voting config exclusions REST API. Closes elastic#41587
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #41587
This PR split the
node_nameparameter before it is processed byresolveNodes