Remove Unused Features Field on StreamOutput #44667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ever since b15d62c this field and all the methods around it seem completely unused (that commit removed the only use of the getter) and are in fact wasting some allocations => removed it
original-brownbear
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra |
| } | ||
|
|
||
| @Override | ||
| public void writeTo(StreamOutput out) throws IOException { | ||
| out.setFeatures(features); |
There was a problem hiding this comment.
This was (and now would have been even more) a weird writeTo that doesn't actually write anything in case of a response. Adjusted the abstractions a little here and just made the request overwrite the message write code to prefix messages with the features array.
|
thanks @tbrooks8 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
are in fact wasting some allocations => removed it