-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove client feature tracking #44929
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the infrastructure for client feature tracking. We introduced this functionality to support clients that do not necessarily understand all the features that the server might support, for example, customs in the cluster state provided by plugins that a client might not have. This can arise in situations such as rolling upgrades from the OSS distribution to the default distribution. With the removal of the transport client, this infrastructure is no longer needed. This commit removes client feature tracking from the server in 8.0.0.
jasontedor
added
>breaking
:Distributed Coordination/Network
Http and internode communication implementations
v8.0.0
labels
Jul 28, 2019
jasontedor
requested review from
rjernst,
Tim-Brooks,
ywelsch and
original-brownbear
July 28, 2019 00:49
Pinging @elastic/es-distributed |
@elasticmachine run elasticsearch-ci/packaging-sample |
rjernst
approved these changes
Jul 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice stats! LGTM
original-brownbear
approved these changes
Jul 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM2 :)
jkakavas
pushed a commit
that referenced
this pull request
Jul 31, 2019
This commit removes the infrastructure for client feature tracking. We introduced this functionality to support clients that do not necessarily understand all the features that the server might support, for example, customs in the cluster state provided by plugins that a client might not have. This can arise in situations such as rolling upgrades from the OSS distribution to the default distribution. With the removal of the transport client, this infrastructure is no longer needed. This commit removes client feature tracking from the server in 8.0.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>breaking
:Distributed Coordination/Network
Http and internode communication implementations
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the infrastructure for client feature tracking. We introduced this functionality to support clients that do not necessarily understand all the features that the server might support, for example, customs in the cluster state provided by plugins that a client might not have. This can arise in situations such as rolling upgrades from the OSS distribution to the default distribution. With the removal of the transport client, this infrastructure is no longer needed. This commit removes client feature tracking from the server in 8.0.0.
Relates #31020
Relates #42538
Relates #44667