Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make xpack.ilm.enabled setting a no-op (#55592) #55980

Conversation

williamrandolph
Copy link
Contributor

@williamrandolph williamrandolph commented Apr 29, 2020

  • Make xpack.ilm.enabled setting a no-op

  • Add watcher setting to not use ILM

  • Update documentation for no-op setting

  • Remove NO_ILM ml index templates

  • Remove unneeded setting from test setup

  • Inline variable definitions for ML templates

  • Use identical parameter names in templates

  • New ILM/watcher setting falls back to old setting

  • Add fallback unit test for watcher/ilm setting

* Make xpack.ilm.enabled setting a no-op

* Add watcher setting to not use ILM

* Update documentation for no-op setting

* Remove NO_ILM ml index templates

* Remove unneeded setting from test setup

* Inline variable definitions for ML templates

* Use identical parameter names in templates

* New ILM/watcher setting falls back to old setting

* Add fallback unit test for watcher/ilm setting
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Plugins)

@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Apr 29, 2020
@williamrandolph
Copy link
Contributor Author

Backport of #55592

@williamrandolph williamrandolph merged commit 273ff6a into elastic:7.x Apr 30, 2020
@williamrandolph williamrandolph deleted the backport/7.x/disabled-ilm-is-no-op branch April 30, 2020 13:50
williamrandolph added a commit to williamrandolph/elasticsearch that referenced this pull request May 6, 2020
It seems that I backported these docs to the wrong place in elastic#56061,
in elastic#55980, and in elastic#56167. I hope they're in the right place now.
williamrandolph added a commit that referenced this pull request May 7, 2020
* Add xpack setting deprecations to deprecation API

The deprecated settings showed up in the deprecation log file by
default, but I did not add them to the deprecation API. This commit
fixes that. Now if you use one of the deprecated basic feature
enablement settings, calling _monitoring/deprecations will inform you of
that fact.

* Remove incorrectly backported settings documents

It seems that I backported these docs to the wrong place in #56061,
in #55980, and in #56167. I hope they're in the right place now.

Co-authored-by: debadair <debadair@elastic.co>
williamrandolph added a commit that referenced this pull request May 7, 2020
* Add xpack setting deprecations to deprecation API

The deprecated settings showed up in the deprecation log file by
default, but I did not add them to the deprecation API. This commit
fixes that. Now if you use one of the deprecated basic feature
enablement settings, calling _monitoring/deprecations will inform you of
that fact.

* Remove incorrectly backported settings documents

It seems that I backported these docs to the wrong place in #56061,
in #55980, and in #56167. I hope they're in the right place now.

Co-authored-by: debadair <debadair@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport :Core/Infra/Plugins Plugin API and infrastructure >deprecation Team:Core/Infra Meta label for core/infra team v7.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants