Add xpack setting deprecations to deprecation API #56290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deprecated settings showed up in the deprecation log file by default, but I did not add them to the deprecation API. This commit fixes that. Now if you use one of the deprecated basic feature enablement settings, calling _monitoring/deprecations will inform you of that fact.
williamrandolph
added
:Core/Infra/Plugins
|
Pinging @elastic/es-core-infra (:Core/Infra/Plugins) |
It seems that I backported these docs to the wrong place in elastic#56061, in elastic#55980, and in elastic#56167. I hope they're in the right place now.
debadair
reviewed
May 6, 2020
gwbrown
approved these changes
May 6, 2020
Co-authored-by: debadair <debadair@elastic.co>
williamrandolph
deleted the
deprecation-api-warnings-for-deprecated-xpack-settings
branch
williamrandolph
added a commit
that referenced
this pull request
May 7, 2020
* Add xpack setting deprecations to deprecation API The deprecated settings showed up in the deprecation log file by default, but I did not add them to the deprecation API. This commit fixes that. Now if you use one of the deprecated basic feature enablement settings, calling _monitoring/deprecations will inform you of that fact. * Remove incorrectly backported settings documents It seems that I backported these docs to the wrong place in #56061, in #55980, and in #56167. I hope they're in the right place now. Co-authored-by: debadair <debadair@elastic.co>
|
Backport to 7.8: 91837fe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deprecated settings showed up in the deprecation log file by default, but I did not add them to the deprecation API. This commit fixes that. Now if you use one of the deprecated basic feature enablement settings, calling _monitoring/deprecations will inform you of that fact.
I believe that this takes care of hooking these changes into the upgrade assistant in Kibana. That is, I verified that the upgrade assistant flags these deprecated settings. But if there is more that I need to do, please let me know.
Meta issue: #54745
EDIT: We are considering this small, targeted change to be a bugfix for the purposes of the 7.8.0 release