SlowLoggers using single logger #56708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slow loggers should use single shared logger as otherwise when index is deleted the log4j logger will remain reachable (log4j is caching) and will create a memory leak.
pgomulka
added
:Core/Infra/Logging
|
Pinging @elastic/es-core-infra (:Core/Infra/Logging) |
|
@elasticmachine run elasticsearch-ci/1 |
jasontedor
reviewed
May 27, 2020
server/src/main/java/org/elasticsearch/index/IndexingSlowLog.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/common/logging/MockAppender.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/common/logging/MockAppender.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/index/SlowLogLevelTest.java
Outdated
Show resolved
Hide resolved
jasontedor
reviewed
May 27, 2020
jasontedor
reviewed
May 27, 2020
jasontedor
reviewed
May 27, 2020
| private long indexInfoThreshold; | ||
| private long indexDebugThreshold; | ||
| private long indexTraceThreshold; | ||
| /** |
There was a problem hiding this comment.
A nit here, sorry: I know this is carried over from the code that you moved, but this is labeled as a Javadoc /** on a private field. It should be a regular comment /*. Also no reason to not make this comment use the full 140 columns that are available. 😇
jasontedor
reviewed
May 27, 2020
| WARN(3), //most specific - little logging | ||
| INFO(2), | ||
| DEBUG(1), | ||
| TRACE(0); //least specific - lots of logging |
There was a problem hiding this comment.
Nit: space between the // and the start of the comment
jasontedor
reviewed
May 27, 2020
| IndexingSlowLog log2 = new IndexingSlowLog(index2Settings); | ||
| context = (LoggerContext) LogManager.getContext(false); | ||
|
|
||
| int numberOfLoggersAfter = context.getLoggers().size(); |
There was a problem hiding this comment.
Maybe we can do this a random number of times, in a loop, say up to 64 or something like that, just to really exercise that no new ones are created?
jasontedor
approved these changes
May 27, 2020
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
May 27, 2020
Slow loggers should use single shared logger as otherwise when index is deleted the log4j logger will remain reachable (log4j is caching) and will create a memory leak. closes elastic#56171
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
May 27, 2020
Slow loggers should use single shared logger as otherwise when index is deleted the log4j logger will remain reachable (log4j is caching) and will create a memory leak. closes elastic#56171
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
May 27, 2020
Slow loggers should use single shared logger as otherwise when index is deleted the log4j logger will remain reachable (log4j is caching) and will create a memory leak. closes elastic#56171
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
May 27, 2020
Slow loggers should use single shared logger as otherwise when index is deleted the log4j logger will remain reachable (log4j is caching) and will create a memory leak. closes elastic#56171
pgomulka
added a commit
that referenced
this pull request
May 27, 2020
pgomulka
added a commit
that referenced
this pull request
May 27, 2020
pgomulka
added a commit
that referenced
this pull request
May 27, 2020
pgomulka
added a commit
that referenced
this pull request
May 28, 2020
|
I'm removing the Backport Pending label since this appears to merged into all the labeled branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slow loggers should use single shared logger as otherwise when index is
deleted the log4j logger will remain reachable (log4j is caching) and
will create a memory leak.
closes #56171