Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SlowLoggers using single logger backport(#56708) #57216

Merged
merged 2 commits into from
May 27, 2020
Merged

SlowLoggers using single logger backport(#56708) #57216

merged 2 commits into from
May 27, 2020

Conversation

pgomulka
Copy link
Contributor

Slow loggers should use single shared logger as otherwise when index is
deleted the log4j logger will remain reachable (log4j is caching) and
will create a memory leak.

closes #56171

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@pgomulka
SlowLoggers using single logger (elastic#56708)
717bbf4 
Slow loggers should use single shared logger as otherwise when index is
deleted the log4j logger will remain reachable (log4j is caching) and
will create a memory leak.

closes elastic#56171
@pgomulka pgomulka added :Core/Infra/Logging Log management and logging utilities backport labels May 27, 2020
@pgomulka pgomulka self-assigned this May 27, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Logging)

@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label May 27, 2020
@pgomulka pgomulka changed the title SlowLoggers using single logger (#56708) SlowLoggers using single logger backport(#56708) May 27, 2020
@pgomulka pgomulka merged commit ff9be2b into elastic:7.7 May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport :Core/Infra/Logging Log management and logging utilities Team:Core/Infra Meta label for core/infra team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pgomulka @elasticmachine