Remove slowlog level #57591
Merged
Remove slowlog level #57591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-core-infra (:Core/Infra/Logging) |
rjernst
approved these changes
Jun 3, 2020
| @@ -18,4 +18,11 @@ Mapping:: | |||
| Deprecations:: | |||
| * Remove undocumented endpoints of hot threads API {pull}55109[#55109] | |||
|
|
|||
| Slow loggers:: | |||
| * `index.indexing.slowlog.level` and `index.indexing.slowlog.level` are removed. These settings can be worked around | |||
There was a problem hiding this comment.
It looks like the settings listed here are the same? One should be the search slowlog level?
|
@elasticmachine update branch |
pgomulka
added a commit
that referenced
this pull request
Jun 3, 2021
Indexing and search slow log level setting is deprecated in 7x as it is removed in master relates #57591
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Jul 19, 2021
settings for slwo log levels are removed in v8. This commit adds a documentation to how to mimic the behaviour relates elastic#57591
pgomulka
added a commit
that referenced
this pull request
Jul 22, 2021
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Jul 22, 2021
settings for slow log levels are removed in v8. This commit adds a documentation to how to mimic the behaviour relates elastic#57591 relates elastic#73718 # Conflicts: # docs/reference/index-modules/slowlog.asciidoc
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Jul 22, 2021
settings for slow log levels are removed in v8. This commit adds a documentation to how to mimic the behaviour relates elastic#57591 relates elastic#73718 # Conflicts: # docs/reference/index-modules/slowlog.asciidoc
pgomulka
added a commit
that referenced
this pull request
Jul 22, 2021
pgomulka
added a commit
that referenced
this pull request
Jul 22, 2021
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
Jul 30, 2021
settings for slow log levels are removed in v8. This commit adds a documentation to how to mimic the behaviour relates elastic#57591 relates elastic#73718
80 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting a slow log level requires an unnecessary conditional logic in
SearchSlowLogandIndexingSlowLogThe behaviour of setting a level on a slow logger can be achieved with correct slow log threshold settings.
This PR is removing slow log and modifies tests to achieve the same behaviour with changing threshold.
relates #56171