Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate slow log level #73718

Merged
merged 5 commits into from
Jun 3, 2021
Merged

Deprecate slow log level #73718

merged 5 commits into from
Jun 3, 2021

Conversation

pgomulka
Copy link
Contributor

@pgomulka pgomulka commented Jun 3, 2021

Indexing and search slow log level setting is deprecated in 7x as it is removed in master

relates #57591

@pgomulka pgomulka self-assigned this Jun 3, 2021
@pgomulka pgomulka requested a review from rjernst June 3, 2021 13:07
rjernst
rjernst approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgomulka pgomulka merged commit b636a0a into elastic:7.x Jun 3, 2021
@probakowski probakowski added the :Core/Infra/Logging Log management and logging utilities label Jul 8, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Jul 8, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@Leaf-Lin
Copy link
Contributor

Leaf-Lin commented Jul 19, 2021 •
edited
Loading

Hi, @pgomulka , I came across this issue because while testing slowlog, I can see correct deprecating message as follows:

#! [index.search.slowlog.level] setting was deprecated in Elasticsearch and will be removed in a future release! See the breaking changes documentation for the next major version.

But I couldn't see anything in the 7.14 doc mentioning this. https://www.elastic.co/guide/en/elasticsearch/reference/7.14/index-modules-slowlog.html

Can we just add a line or two in the doc above from the migration guide?
https://github.com/elastic/elasticsearch/pull/73718/files#diff-c2605a61b8ed26d6ea4c66dbd4caac554c673001c698cc37e92d5f3947c930ff

Slow loggers::

  • index.indexing.slowlog.level and index.search.slowlog.level are deprecated. These settings can be worked around by using appropriate thresholds. If for instance we want to simulate index.indexing.slowlog.level = INFO then
    all we need to do is to set index.indexing.slowlog.threshold.index.debug and
    index.indexing.slowlog.threshold.index.trace to -1

@pgomulka pgomulka mentioned this pull request Jul 19, 2021
Merged
@pgomulka
Copy link
Contributor Author

hey @Leaf-Lin I think it is a good idea. I will try to add a doc, without mentioning the previous settings so that it is the same in master and 7.x
#75438

pgomulka added a commit that referenced this pull request Jul 22, 2021
@pgomulka
[doc] Document workaround for slow log levels (#75438)
1127f4f 
settings for slow log levels are removed in v8. This commit adds a
documentation to how to mimic the behaviour
relates #57591
relates #73718
pgomulka added a commit to pgomulka/elasticsearch that referenced this pull request Jul 22, 2021
@pgomulka
[doc] Document workaround for slow log levels (elastic#75438)
c17e15d 
settings for slow log levels are removed in v8. This commit adds a
documentation to how to mimic the behaviour
relates elastic#57591
relates elastic#73718
# Conflicts:
#	docs/reference/index-modules/slowlog.asciidoc
pgomulka added a commit to pgomulka/elasticsearch that referenced this pull request Jul 22, 2021
@pgomulka
[doc] Document workaround for slow log levels (elastic#75438)
98f72f5 
settings for slow log levels are removed in v8. This commit adds a
documentation to how to mimic the behaviour
relates elastic#57591
relates elastic#73718
# Conflicts:
#	docs/reference/index-modules/slowlog.asciidoc
pgomulka added a commit that referenced this pull request Jul 22, 2021
@pgomulka
[doc] Document workaround for slow log levels (#75438) (#75633)
fef5f8b 
settings for slow log levels are removed in v8. This commit adds a
documentation to how to mimic the behaviour
relates #57591
relates #73718
pgomulka added a commit that referenced this pull request Jul 22, 2021
@pgomulka
[7.x] [doc] Document workaround for slow log levels (#75438) (#75632)
3a6e90c 
settings for slow log levels are removed in v8. This commit adds a
documentation to how to mimic the behaviour
relates #57591
relates #73718
ywangd pushed a commit to ywangd/elasticsearch that referenced this pull request Jul 30, 2021
@pgomulka @ywangd
[doc] Document workaround for slow log levels (elastic#75438)
3ccc8e3 
settings for slow log levels are removed in v8. This commit adds a
documentation to how to mimic the behaviour
relates elastic#57591
relates elastic#73718
@jrodewig jrodewig mentioned this pull request Sep 15, 2021
Merged
jrodewig added a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Fix deprecation docs for slow log levels (#77811)
213c4d4 
In 7.13 and later 7.x versions, the `index.indexing.slowlog.level` and
`index.search.slowlog.level` index settings are deprecated, not removed.

This corrects the related item in the 7.13 breaking changes.

Relates to #73718
jrodewig added a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Fix deprecation docs for slow log levels (#77811) (#77918)
1a7ed3e 
In 7.13 and later 7.x versions, the `index.indexing.slowlog.level` and
`index.search.slowlog.level` index settings are deprecated, not removed.

This corrects the related item in the 7.13 breaking changes.

Relates to #73718
jrodewig added a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Fix deprecation docs for slow log levels (#77811) (#77919)
ef7df3c 
In 7.13 and later 7.x versions, the `index.indexing.slowlog.level` and
`index.search.slowlog.level` index settings are deprecated, not removed.

This corrects the related item in the 7.13 breaking changes.

Relates to #73718
jrodewig added a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Fix deprecation docs for slow log levels (#77811) (#77920)
17621a1 
In 7.13 and later 7.x versions, the `index.indexing.slowlog.level` and
`index.search.slowlog.level` index settings are deprecated, not removed.

This corrects the related item in the 7.13 breaking changes.

Relates to #73718
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjernst rjernst rjernst approved these changes

Assignees
No one assigned
Labels
:Core/Infra/Logging Log management and logging utilities >deprecation Team:Core/Infra Meta label for core/infra team v7.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pgomulka @elasticmachine @Leaf-Lin @rjernst @probakowski